Bug 33394

Summary: Optimize the number of CPUs used for building Qt and Gtk
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-01-08 12:00:43 PST
Optimize the number of CPUs used for building Qt and Gtk
Attachments
Patch (4.83 KB, patch)
2010-01-08 12:01 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.07 KB, patch)
2010-01-08 14:18 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-08 12:01:35 PST
Created attachment 46149 [details] Patch
WebKit Review Bot
Comment 2 2010-01-08 12:05:14 PST
style-queue ran check-webkit-style on attachment 46149 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-08 12:36:39 PST
Comment on attachment 46149 [details] Patch LGTM!
Adam Barth
Comment 4 2010-01-08 13:11:59 PST
Comment on attachment 46149 [details] Patch I'm excited that that commit-queue runs test-webkitpy for me!
WebKit Commit Bot
Comment 5 2010-01-08 14:14:30 PST
Comment on attachment 46149 [details] Patch Rejecting patch 46149 from commit-queue. Failed to run "['WebKitTools/Scripts/test-webkitpy']" exit_code: 1 Last 500 characters of output: webkitpy/webkitport_unittest.py", line 57, in test_qt_port self.assertEquals(QtPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--qt", '--makeargs="-j8"']) AssertionError: ['WebKitTools/Scripts/build-webkit', '--debug', '--qt', '--makeargs="-j2"'] != ['WebKitTools/Scripts/build-webkit', '--debug', '--qt', '--makeargs="-j8"'] ---------------------------------------------------------------------- Ran 226 tests in 0.908s FAILED (failures=1) Full output: http://webkit-commit-queue.appspot.com/results/171078
Adam Barth
Comment 6 2010-01-08 14:18:13 PST
Created attachment 46162 [details] Patch
WebKit Commit Bot
Comment 7 2010-01-08 14:46:03 PST
Comment on attachment 46162 [details] Patch Clearing flags on attachment: 46162 Committed r53011: <http://trac.webkit.org/changeset/53011>
WebKit Commit Bot
Comment 8 2010-01-08 14:46:08 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 9 2010-01-08 15:27:57 PST
Why did it fail on the commit-bot?
Adam Barth
Comment 10 2010-01-08 15:31:34 PST
(In reply to comment #9) > Why did it fail on the commit-bot? One of the expected results in test-webkitpy was set to 8, which happens to be the number of cores on my machine.
Note You need to log in before you can comment on or make changes to this bug.