Bug 33382
| Summary: | Bring the Mozilla JavaScript tests up-to-date | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Hansen <kent.hansen> |
| Component: | Tools / Tests | Assignee: | Kent Hansen <kent.hansen> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | ap, cmarcelo, jwalden+bwo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Kent Hansen
The tests under JavaScriptCore/tests/mozilla were imported into trunk in October 2003. It would be nice to try to update them to the most recent tests from Mozilla trunk.
1) This would increase test coverage (adding the ES5 tests, for example), and 2) Mozilla have made behavioral changes since the tests were imported, and consequently updated their tests (see e.g. https://bugs.webkit.org/show_bug.cgi?id=33319); in such cases we should consider whether JavaScriptCore should adopt the same behavior.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kent Hansen
Some potential issues I noticed with doing a "batch-update":
1) Mozilla's tests use tabs. These were not converted to spaces when imported into WebKit trunk. Should they be when importing the updated tests?
2) The indentation is different.
3) Some Mozilla tests have been patched in WebKit trunk. Care must be taken so that those are preserved (i.e. check whether the updated tests cover those changes, or if they must be kept).
4) Different license headers ("Netscape Public License" vs "Mozilla Public License").
Alexey Proskuryakov
> 1) Mozilla's tests use tabs. These were not converted to spaces when imported
> into WebKit trunk. Should they be when importing the updated tests?
> 2) The indentation is different.
I think that these aspects should be preserved for easier merging of changes in the future.