Bug 33341

Summary: webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-01-07 12:59:36 PST
webkit-patch edit-changelogs (or upload) will open blank files if run outside the root EditChangeLogs step probably needs to use absolute paths. The relative paths it currently uses are wrong any time you're not running it from the root of your checkout. This is bad news bears. Shows you a blank ChangeLog entry and creates a new directory (if you're using vi).
Attachments
Patch (2.22 KB, patch)
2010-01-07 14:01 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-07 14:01:07 PST
Created attachment 46085 [details] Patch
WebKit Review Bot
Comment 2 2010-01-07 14:09:13 PST
style-queue ran check-webkit-style on attachment 46085 [details] without any errors.
Eric Seidel (no email)
Comment 3 2010-01-07 14:31:32 PST
Comment on attachment 46085 [details] Patch Hum... OK. We could also just make the paths be absolute. Sad there are no tests here. :(
WebKit Commit Bot
Comment 4 2010-01-07 20:58:17 PST
Comment on attachment 46085 [details] Patch Clearing flags on attachment: 46085 Committed r52968: <http://trac.webkit.org/changeset/52968>
WebKit Commit Bot
Comment 5 2010-01-07 20:58:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.