Bug 33341

Summary: webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-01-07 12:59:36 PST 
webkit-patch edit-changelogs (or upload) will open blank files if run outside the root

EditChangeLogs step probably needs to use absolute paths.  The relative paths it currently uses are wrong any time you're not running it from the root of your checkout.

This is bad news bears.  Shows you a blank ChangeLog entry and creates a new directory (if you're using vi).
Comment 1 Adam Barth 2010-01-07 14:01:07 PST 
Created attachment 46085 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-07 14:09:13 PST 
style-queue ran check-webkit-style on attachment 46085 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-07 14:31:32 PST 
Comment on attachment 46085 [details]
Patch

Hum... OK.  We could also just make the paths be absolute.

Sad there are no tests here. :(
Comment 4 WebKit Commit Bot 2010-01-07 20:58:17 PST 
Comment on attachment 46085 [details]
Patch

Clearing flags on attachment: 46085

Committed r52968: <http://trac.webkit.org/changeset/52968>
Comment 5 WebKit Commit Bot 2010-01-07 20:58:23 PST 
All reviewed patches have been landed.  Closing bug.