Bug 33340

Summary:

Inspector font for errors is ugly on non-OSX platforms

Product:

WebKit

Reporter:

Evan Martin <evan>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
screenshot showing bad font	none
https://bugs.webkit.org/show_bug.cgi?id=33340	none

Evan Martin

Reported 2010-01-07 12:50:42 PST

Created attachment 46074 [details] Patch One font used in the inspector doesn't look too good if you don't have Lucida Grande.

Attachments
Patch (420 bytes, patch) 2010-01-07 12:50 PST, Evan Martin	no flags	Details Formatted Diff Diff
screenshot showing bad font (144.94 KB, image/png) 2010-01-07 12:51 PST, Evan Martin	no flags	Details
https://bugs.webkit.org/show_bug.cgi?id=33340 (990 bytes, patch) 2010-01-07 12:59 PST, Evan Martin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Evan Martin

Comment 1 2010-01-07 12:51:14 PST

Created attachment 46075 [details] screenshot showing bad font

Darin Adler

Comment 2 2010-01-07 12:51:44 PST

Comment on attachment 46074 [details] Patch review- because this has no change log Feel free to mark reviewed by me if you do add one.

Evan Martin

Comment 3 2010-01-07 12:59:57 PST

Created attachment 46077 [details] https://bugs.webkit.org/show_bug.cgi?id=33340

WebKit Review Bot

Comment 4 2010-01-07 13:03:55 PST

style-queue ran check-webkit-style on attachment 46077 [details] without any errors.

Eric Seidel (no email)

Comment 5 2010-01-07 13:28:10 PST

Comment on attachment 46077 [details] https://bugs.webkit.org/show_bug.cgi?id=33340 LGTM too.

WebKit Commit Bot

Comment 6 2010-01-09 16:18:13 PST

Comment on attachment 46077 [details] https://bugs.webkit.org/show_bug.cgi?id=33340 Clearing flags on attachment: 46077 Committed r53042: <http://trac.webkit.org/changeset/53042>

WebKit Commit Bot

Comment 7 2010-01-09 16:18:18 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.