Summary: | [Qt] pass plugins/open-and-close-window-with-plugin.html on Qt | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Hogan <robert> | ||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, eric, kenneth, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Robert Hogan
2010-01-07 11:24:40 PST
Created attachment 46069 [details]
Patch
style-queue ran check-webkit-style on attachment 46069 [details] without any errors.
Comment on attachment 46069 [details]
Patch
Are you sure it can't pass on platforms other than Mac? I don't think it's been a problem on anything but Qt. I think the right fix may be to put this test in the Qt skipped list. r- to consider that option (or just reflag if you are sure this is the best approach).
(In reply to comment #3) > (From update of attachment 46069 [details]) > Are you sure it can't pass on platforms other than Mac? I don't think it's been a problem on anything but Qt. I think the right fix may be to put this test in the Qt skipped list. r- to consider that option (or just reflag if you are sure this is the best approach). It's skipped by everyone except chromium: LayoutTests/platform/mac-snowleopard/Skipped:plugins/open-and-close-window-with-plugin.html LayoutTests/platform/qt/Skipped:plugins/open-and-close-window-with-plugin.html LayoutTests/platform/gtk/Skipped:plugins/open-and-close-window-with-plugin.html LayoutTests/platform/win/Skipped:plugins/open-and-close-window-with-plugin.html Created attachment 58603 [details]
Patch
(In reply to comment #5) > Created an attachment (id=58603) [details] > Patch Maybe it's ok/expected that QWebPage can receive the call to javasriptConsoleMessage() once DRT's WebPage is deleted. I'm not sure, so putting this up as a solution for discussion. Comment on attachment 58603 [details]
Patch
scary :) r=me
Committed r61346: <http://trac.webkit.org/changeset/61346> Reverted r61346 for reason: Broke inspector tests on Qt Committed r61348: <http://trac.webkit.org/changeset/61348> Created attachment 59034 [details]
Patch
Comment on attachment 59034 [details]
Patch
I dont get it. The WebPage inherits from QWebPage, and you say that the WebPage part has been destroyed but not the QWebPage one? Wouldn't it be better to fix the destruction?
(In reply to comment #11) > (From update of attachment 59034 [details]) > I dont get it. The WebPage inherits from QWebPage, and you say that the WebPage part has been destroyed but not the QWebPage one? Wouldn't it be better to fix the destruction? Apparently now that I am reading your original comment Committed r61433: <http://trac.webkit.org/changeset/61433> |