Bug 33297

Summary: Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dbates, hausmann, laszlo.gombos, ossy, vestbo, zimmermann
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 29328, 33008, 33276, 33303, 33342, 33437, 33460, 33542, 33653, 33976, 37334    
Bug Blocks: 33296    
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-01-06 20:49:27 PST 
Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/buildbot.py#L47

This is a master bug for tracking reliability issues (aka flakey tests) with the Qt bot which block us from adding it to the list of builders which block the commit-queue and cause "bugzilla-tool land-diff" to error out when people try to land (unless they pass --ignore-builders).

The Qt bot seems pretty stable, so maybe it's time to add it to the list.  If we encounter any flakey tests with the Qt bot, we can relate them to this bug.

I think I'll code up a patch to add Qt to the list of core builders tomorrow unless I hear objections from folks.
Comment 1 Eric Seidel (no email) 2010-04-13 21:18:57 PDT 
Created attachment 53308 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-13 21:22:46 PDT 
The bots are all green, and have been green most of the day.  I think it's time we try.
Comment 3 Adam Roben (:aroben) 2010-04-13 21:26:05 PDT 
Comment on attachment 53308 [details]
Patch

r=me
Comment 4 Eric Seidel (no email) 2010-04-13 23:10:26 PDT 
Comment on attachment 53308 [details]
Patch

Clearing flags on attachment: 53308

Committed r57561: <http://trac.webkit.org/changeset/57561>
Comment 5 Eric Seidel (no email) 2010-04-13 23:10:37 PDT 
All reviewed patches have been landed.  Closing bug.