Bug 33241

Summary: [Chromium] Fixing texImage2D, texSubImage2D for the chromium build
Product: WebKit Reporter: Rachel Petterson <rlp>
Component: WebKit APIAssignee: Rachel Petterson <rlp>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, cmarrin, dglazkov, eric, fishd, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 31562    
Bug Blocks:    
Attachments:
Description Flags
Patch to fix texImage2D, texSubImage2D for chromium.
none
Slightly modified patch only removing tab characters none

Description Rachel Petterson 2010-01-05 17:14:06 PST
Update from bug 31562 broke the chromium build. This change puts in the fixes.
Comment 1 Rachel Petterson 2010-01-05 17:20:10 PST
Created attachment 45945 [details]
Patch to fix texImage2D, texSubImage2D for chromium.

Patch to fix texImage2D, texSubImage2D for chromium.
Comment 2 WebKit Review Bot 2010-01-05 17:57:20 PST
Attachment 45945 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2
Comment 3 Kenneth Russell 2010-01-05 18:31:12 PST
Created attachment 45952 [details]
Slightly modified patch only removing tab characters

Updating patch for Rachel to pass style-queue in case this can be reviewed and committed tonight.
Comment 4 WebKit Review Bot 2010-01-05 18:33:13 PST
style-queue ran check-webkit-style on attachment 45952 [details] without any errors.
Comment 5 Adam Barth 2010-01-05 18:45:21 PST
Comment on attachment 45952 [details]
Slightly modified patch only removing tab characters

This looks reasonable.  I can land it.
Comment 6 Adam Barth 2010-01-05 18:46:34 PST
Comment on attachment 45952 [details]
Slightly modified patch only removing tab characters

Clearing flags on attachment: 45952

Committed r52845: <http://trac.webkit.org/changeset/52845>
Comment 7 Adam Barth 2010-01-05 18:46:42 PST
All reviewed patches have been landed.  Closing bug.