Bug 33241

Summary: [Chromium] Fixing texImage2D, texSubImage2D for the chromium build
Product: WebKit Reporter: Rachel Petterson <rlp>
Component: WebKit APIAssignee: Rachel Petterson <rlp>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, cmarrin, dglazkov, eric, fishd, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 31562    
Bug Blocks:    
Attachments:
Description Flags
Patch to fix texImage2D, texSubImage2D for chromium.
none
Slightly modified patch only removing tab characters none

Rachel Petterson
Reported 2010-01-05 17:14:06 PST
Update from bug 31562 broke the chromium build. This change puts in the fixes.
Attachments
Patch to fix texImage2D, texSubImage2D for chromium. (5.04 KB, patch)
2010-01-05 17:20 PST, Rachel Petterson 		no flags
DetailsFormatted DiffDiff
Slightly modified patch only removing tab characters (5.06 KB, patch)
2010-01-05 18:31 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rachel Petterson
Comment 1 2010-01-05 17:20:10 PST
Created attachment 45945 [details] Patch to fix texImage2D, texSubImage2D for chromium. Patch to fix texImage2D, texSubImage2D for chromium.
WebKit Review Bot
Comment 2 2010-01-05 17:57:20 PST
Attachment 45945 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 2
Kenneth Russell
Comment 3 2010-01-05 18:31:12 PST
Created attachment 45952 [details] Slightly modified patch only removing tab characters Updating patch for Rachel to pass style-queue in case this can be reviewed and committed tonight.
WebKit Review Bot
Comment 4 2010-01-05 18:33:13 PST
style-queue ran check-webkit-style on attachment 45952 [details] without any errors.
Adam Barth
Comment 5 2010-01-05 18:45:21 PST
Comment on attachment 45952 [details] Slightly modified patch only removing tab characters This looks reasonable. I can land it.
Adam Barth
Comment 6 2010-01-05 18:46:34 PST
Comment on attachment 45952 [details] Slightly modified patch only removing tab characters Clearing flags on attachment: 45952 Committed r52845: <http://trac.webkit.org/changeset/52845>
Adam Barth
Comment 7 2010-01-05 18:46:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.