Bug 33238 – run-webkit-tests should catch control-C and offer to show you the failures/diffs so far

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

run-webkit-tests should catch control-C and offer to show you the failures/diffs so far

I would find this useful.  If we don't implement it in the perl version we should be sure to add it to the python version once it's upstream.

[Alexey Proskuryakov]

That would be awesome!

[Dirk Pranke]

Created attachment 56771 [details]
Patch

[Dirk Pranke]

Patch added. Note that I decided that prompting the user would just be annoying, so we go ahead and display the results we have.

Also, this patch changes the code to explicitly catch a ctrl-C and call sys.exit(); if you don't do that, Python waits for all of the threads currently exiting to complete. If some threads are wedged and don't get the interrupt, the process hangs and can't be killed.

[Dirk Pranke]

(In reply to comment #3)
> Patch added. Note that I decided that prompting the user would just be annoying, so we go ahead and display the results we have. 

Of course, if no tests have failed, there's nothing to display.

Note that we can certainly change the behavior if it is annoying this way.

[Ojan Vafai]

Comment on attachment 56771 [details]
Patch

This is a great change.

WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:290
 +              exp_str = str(expected)
Both these abbreviations are hard to read. incomplete_str and expected_str are much more readable.

WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:765
 +              not self._retrying and not interrupted):
Nit: here and above, can you call this keyboard_interrupted? Makes it more clear what this means without having to trace back to where this was set.

[Dirk Pranke]

(In reply to comment #5)
> (From update of attachment 56771 [details])
> This is a great change.
> 
> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:290
>  +              exp_str = str(expected)
> Both these abbreviations are hard to read. incomplete_str and expected_str are much more readable.
>

Done.
 
> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:765
>  +              not self._retrying and not interrupted):
> Nit: here and above, can you call this keyboard_interrupted? Makes it more clear what this means without having to trace back to where this was set.

Done.

[Dirk Pranke]

Committed r60381: <http://trac.webkit.org/changeset/60381>