Summary: | run-webkit-tests should catch control-C and offer to show you the failures/diffs so far | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, dpranke, jamesr | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-01-05 17:06:06 PST
That would be awesome! Created attachment 56771 [details]
Patch
Patch added. Note that I decided that prompting the user would just be annoying, so we go ahead and display the results we have. Also, this patch changes the code to explicitly catch a ctrl-C and call sys.exit(); if you don't do that, Python waits for all of the threads currently exiting to complete. If some threads are wedged and don't get the interrupt, the process hangs and can't be killed. (In reply to comment #3) > Patch added. Note that I decided that prompting the user would just be annoying, so we go ahead and display the results we have. Of course, if no tests have failed, there's nothing to display. Note that we can certainly change the behavior if it is annoying this way. Comment on attachment 56771 [details]
Patch
This is a great change.
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:290
+ exp_str = str(expected)
Both these abbreviations are hard to read. incomplete_str and expected_str are much more readable.
WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:765
+ not self._retrying and not interrupted):
Nit: here and above, can you call this keyboard_interrupted? Makes it more clear what this means without having to trace back to where this was set.
(In reply to comment #5) > (From update of attachment 56771 [details]) > This is a great change. > > WebKitTools/Scripts/webkitpy/layout_tests/layout_package/printing.py:290 > + exp_str = str(expected) > Both these abbreviations are hard to read. incomplete_str and expected_str are much more readable. > Done. > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:765 > + not self._retrying and not interrupted): > Nit: here and above, can you call this keyboard_interrupted? Makes it more clear what this means without having to trace back to where this was set. Done. Committed r60381: <http://trac.webkit.org/changeset/60381> |