Summary: | check-webkit-style should warn about tabs in any file | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | abarth, cjerdonek, hamaji, levin, tkent |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 | ||
Bug Depends on: | 33734 | ||
Bug Blocks: |
Description
Eric Seidel (no email)
2010-01-05 12:21:31 PST
I don't see any reason to forbid tabs in regression tests (not to mention make files). We should use the same rules as the pre-commit hook. (In reply to comment #1) > I don't see any reason to forbid tabs in regression tests (not to mention make > files). Agreed. fwiw, I purposely got regression tests (directories) omitted when I reviewed the change that checks for TABs. I think we may have a whitelist for tab checking. For example, we may forbid tabs in LayoutTests/.../script-tests/*.js the pre-commit hook warns unless you set the svn property "allow-tabs". check-webkit-style should do the same. svn patches from svn-create-patch include properties on new files. For existing files we can teach scm.py how to expose the current properties on a file. |