|Summary:||check-webkit-style should warn about tabs in any file|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, cjerdonek, hamaji, levin, tkent|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
|Bug Depends on:||33734|
Description Eric Seidel (no email) 2010-01-05 12:21:31 PST
check-webkit-style should warn about tabs in any file At least I think this should be check-webkit-style's job. https://bugs.webkit.org/show_bug.cgi?id=33221#c3
Comment 1 Alexey Proskuryakov 2010-01-05 18:47:23 PST
I don't see any reason to forbid tabs in regression tests (not to mention make files).
Comment 2 Adam Barth 2010-01-05 18:58:55 PST
We should use the same rules as the pre-commit hook.
Comment 3 David Levin 2010-01-05 19:05:04 PST
(In reply to comment #1) > I don't see any reason to forbid tabs in regression tests (not to mention make > files). Agreed. fwiw, I purposely got regression tests (directories) omitted when I reviewed the change that checks for TABs.
Comment 4 Kent Tamura 2010-01-06 01:56:37 PST
I think we may have a whitelist for tab checking. For example, we may forbid tabs in LayoutTests/.../script-tests/*.js
Comment 5 Eric Seidel (no email) 2010-01-06 06:31:44 PST
the pre-commit hook warns unless you set the svn property "allow-tabs". check-webkit-style should do the same. svn patches from svn-create-patch include properties on new files. For existing files we can teach scm.py how to expose the current properties on a file.