Bug 33204

Summary: [Qt] Assertion failure in SelectionController::recomputeCaretRect()
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, laszlo.gombos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds()
none
Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. none

Andreas Kling
Reported 2010-01-05 02:59:03 PST
Introduced by http://trac.webkit.org/changeset/52778
Attachments
Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds() (1.10 KB, patch)
2010-01-05 03:08 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. (1.20 KB, patch)
2010-01-05 05:18 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-01-05 03:00:42 PST
ASSERTION FAILED: !m_frame->view() || !m_frame->view()->needsLayout() (../../../WebCore/editing/SelectionController.cpp:929 bool WebCore::SelectionController::recomputeCaretRect()) The problem originates in QWebPage::inputMethodQuery(Qt::ImMicroFocus) which calls SelectionController::absoluteCaretBounds() when the view needs to layout.
Andreas Kling
Comment 2 2010-01-05 03:08:46 PST
Created attachment 45879 [details] Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds()
WebKit Review Bot
Comment 3 2010-01-05 03:11:27 PST
style-queue ran check-webkit-style on attachment 45879 [details] without any errors.
Simon Hausmann
Comment 4 2010-01-05 03:15:59 PST
Comment on attachment 45879 [details] Trigger a layout (if needed) before calling SelectionController::absoluteCaretBounds() r=me, appears consistent with similar changes in r52778
Andreas Kling
Comment 5 2010-01-05 05:18:53 PST
Created attachment 45882 [details] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. There was more than one way to trigger that assertion, so instead of hacking our way out of it, just return an invalid ImMicroFocus if called at a bad time.
WebKit Review Bot
Comment 6 2010-01-05 05:24:11 PST
style-queue ran check-webkit-style on attachment 45882 [details] without any errors.
WebKit Commit Bot
Comment 7 2010-01-06 23:08:01 PST
Comment on attachment 45882 [details] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout. Clearing flags on attachment: 45882 Committed r52903: <http://trac.webkit.org/changeset/52903>
WebKit Commit Bot
Comment 8 2010-01-06 23:08:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.