| Summary: | [V8] Move createWindow into generic bindings so it can be shared with JSC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | creis, dglazkov, mjs, sam, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2010-01-05 01:12:27 PST
Created attachment 45872 [details]
Patch
style-queue ran check-webkit-style on attachment 45872 [details] without any errors.
Comment on attachment 45872 [details]
Patch
ok. I am learning about this generic binding from this patch -- it looks pretty interesting. I am assuming this is very much in flux still, so I'll follow along.
I am assuming State<Binding> -> ScriptState? Or is this going to be a more generic concept?
> I am assuming State<Binding> -> ScriptState? Or is this going to be a more
> generic concept?
The Script* types are WebCore's view of the bindings. The templated objects are the generic bindings view of the engine-specific bindings. I want to see how far I can push things, but eventually we might hope that the templated objects are a relatively thin layer around the JavaScript engine itself.
To specifically answer your question, State<Binding> is ExecState for JSC and nothing for V8 (because V8 uses statics instead of a state object).
Another way to think about this is to look at ScriptValue and Bindings::Value. ScriptValue uses a persistent handle with a managed lifetime, which is how WebCore wants to think about the bindings, but that's slow and memory intensive. Bindings::Value is just a regular value handle, which means zero overhead.
Comment on attachment 45872 [details] Patch Clearing flags on attachment: 45872 Committed r52810: <http://trac.webkit.org/changeset/52810> All reviewed patches have been landed. Closing bug. Created attachment 63860 [details]
Patch
Comment on attachment 63860 [details]
Patch
Commit message confused webkit-patch.
|