Summary: | REGRESSION (412+): printing of images is broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Sullivan <sullivan> | ||||
Component: | Printing | Assignee: | Darin Adler <darin> | ||||
Status: | VERIFIED FIXED | ||||||
Severity: | Major | ||||||
Priority: | P1 | ||||||
Version: | 412 | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
John Sullivan
2005-06-07 16:11:53 PDT
This is also in Radar as <rdar://problem/4141569> It turns out that all printing is broken, including Preview and Save as PDF. I suspect something broke in the SPI reshuffling just before we open-sourced WebKit. It turns out (it sure keeps turning) that not all printing is broken, but printing of images is broken. Printing a page consisting of nothing but text and form elements works fine. Printing a page with only a single image fails (even the missing image image). Turns out this is a bug due to a subtle issue with graphics contexts. If you retain a pointer to the graphics context, you break printing. And we were using autoreleased NSGraphicsContext pointers. Fix is simple. Created attachment 2282 [details]
adds autorelease pools to fix the bug; also change tabs to spaces
This patch fixes the bug, and also changes the various tabs in this file to
spaces.
r=me Verified with TOT WebKit (6/18) under 10.4.1. Marking Verified. |