Summary: | [WinCairo] Improper Cairo Surface Type Sometimes Used | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Brent Fulgham
2010-01-04 11:47:08 PST
Created attachment 45811 [details]
Check bitmap validity, only construct 32-bit surface when needed.
style-queue ran check-webkit-style on attachment 45811 [details] without any errors.
Comment on attachment 45811 [details] Check bitmap validity, only construct 32-bit surface when needed. > + if (!GetObject(bitmap, sizeof(info), &info)) > + surface = cairo_win32_surface_create(hdc); Does this surface have an associated bitmap? Do we need to select it into the DC? Please add a link to this bug in the ChangeLog. r=me (In reply to comment #3) > (From update of attachment 45811 [details]) > > + if (!GetObject(bitmap, sizeof(info), &info)) > > + surface = cairo_win32_surface_create(hdc); > > Does this surface have an associated bitmap? Do we need to select it into the > DC? > > Please add a link to this bug in the ChangeLog. > > r=me No, the created surface references whatever is currently in the DC. The only reason for the second path is to create a 32-bit image bitmap backing store so that alpha effects can be handled properly. Landed in http://trac.webkit.org/changeset/52752. |