Bug 33019

Summary:

[Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	none

Description Laszlo Gombos 2009-12-29 07:06:23 PST

In debug builds:

WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: In member function ‘void WebCore::MediaPlayerPrivate::totalTimeChanged(qint64)’:
WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:505: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘qint64’

In release builds:

WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:511:
WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:49: warning: ‘QByteArray debugMediaObject(WebCore::MediaPlayerPrivate*, const Phonon::MediaObject&)’ defined but not used

Comment 1 Laszlo Gombos 2009-12-29 07:23:03 PST

Created attachment 45601 [details]
proposed patch

Comment 2 WebKit Commit Bot 2009-12-29 07:33:05 PST

Comment on attachment 45601 [details]
proposed patch

Clearing flags on attachment: 45601

Committed r52621: <http://trac.webkit.org/changeset/52621>

Comment 3 WebKit Commit Bot 2009-12-29 07:33:10 PST

All reviewed patches have been landed.  Closing bug.