Bug 3301

Summary:

innerHTML does not work for xhtml documents

Product:

WebKit

Reporter:

Nicholas Shanks <nickshanks>

Component:

XML

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, mjs

Priority:

Version:

412

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Implement setting innerHTML for xhtml documents	mjs: review+

Nicholas Shanks

Reported 2005-06-07 08:32:44 PDT

When an XML page is transformed via a stylesheet to (X)HTML, and the resulting HTML has an onload script in it's body tag, this script is not executed. An example can be found at http://astro.nickshanks.com/library/extrasolar.xml Pre-processed HTML output can be found at http://astro.nickshanks.com/library/extrasolar.en The two pages should look identical. The latter was produced by libxslt processing of the former.

Attachments
Implement setting innerHTML for xhtml documents (9.17 KB, patch) 2005-08-05 00:59 PDT, Anders Carlsson	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2005-06-07 08:43:15 PDT

I believe this has been fixed recently. Given that page has other issues (like the DTD issue) can you attach a simpler test case just so we can verify?

Nicholas Shanks

Comment 2 2005-06-07 09:17:57 PDT

Test case: http://web.nickshanks.com/safari/xslt-js.xml (fails with 412) HTML Version: http://web.nickshanks.com/safari/xslt-js.html (passes with 412) XSL used: http://web.nickshanks.com/safari/xslt-js.xsl

Dave Hyatt

Comment 3 2005-06-07 09:21:54 PDT

Hmmm, I was wrong. This does not pass.

Darin Adler

Comment 4 2005-06-07 09:25:27 PDT

The bug I fixed recently is fixes the test case in layout tests: fast/events/xsl-onload.xhtml. I guess the test case attached here wasn't fixed by that change.

Anders Carlsson

Comment 5 2005-07-14 01:37:07 PDT

Turns out that this bug was a completely different one. I'm working on this so I'll reassign it to me.

Anders Carlsson

Comment 6 2005-08-05 00:59:05 PDT

Created attachment 3228 [details] Implement setting innerHTML for xhtml documents

Darin Adler

Comment 7 2005-08-06 12:14:09 PDT

Comment on attachment 3228 [details] Implement setting innerHTML for xhtml documents In the past Dave Hyatt has suggested that things like innerHTML should not be implemented for XML documents. I'd like to hear his take on this. Other than that, this looks good.

Anders Carlsson

Comment 8 2005-08-06 12:16:25 PDT

OK. For the record, Deer Park has this feature now and that's kinda why I implemented it.

Maciej Stachowiak

Comment 9 2005-08-17 23:07:00 PDT

Comment on attachment 3228 [details] Implement setting innerHTML for xhtml documents looks good r=me

Note You need to log in before you can comment on or make changes to this bug.