Bug 32987

Summary:

Add build option ENABLE_XHTMLMP to Mac, GTK, and Chromium build systems

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, dglazkov, eric, jmalonzo, mrowe, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	eric: review+, eric: commit-queue-

Daniel Bates

Reported 2009-12-28 09:57:11 PST

We should add the build option to enable XHTML-MP support to the Mac, GTK, and Chromium build systems (disabled by default). Currently, passing the command-line argument --enable-xhtmlmp to build-webkit is only honored by the Qt and Windows builds.

Attachments
Patch (16.17 KB, patch) 2010-01-04 12:16 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (16.17 KB, patch) 2010-01-04 12:38 PST, Daniel Bates	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-01-04 12:16:41 PST

Created attachment 45815 [details] Patch

WebKit Review Bot

Comment 2 2010-01-04 12:17:28 PST

style-queue ran check-webkit-style on attachment 45815 [details] without any errors.

WebKit Review Bot

Comment 3 2010-01-04 12:24:03 PST

Attachment 45815 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/161668

Daniel Bates

Comment 4 2010-01-04 12:36:07 PST

CC'ing people knowledgeable about the various build systems, including Csaba Osztrogonac, Jan Alonzo, Eric Seidel, Adam Roben, and Mark Rowe

Daniel Bates

Comment 5 2010-01-04 12:38:53 PST

Created attachment 45817 [details] Patch Added missing comma after 'ENABLE_XHTMLMP=0' in WebKit/chromium/features.gypi.

WebKit Review Bot

Comment 6 2010-01-04 12:43:14 PST

style-queue ran check-webkit-style on attachment 45817 [details] without any errors.

Csaba Osztrogonác

Comment 7 2010-01-04 13:44:19 PST

WebKitTools/Scripts/build-webkit script pass to Qt build system if XHTML-MP is enabled or disabled. Now it is disabled by default, you can enable explicitly with: WebKitTools/Scripts/build-webkit --xhtmlmp If you would like to use different default value for Qt port, you should put one of this line into WebCore.pro !contains(DEFINES, ENABLE_XHTMLMP=.): DEFINES += ENABLE_XHTMLMP=0 or !contains(DEFINES, ENABLE_XHTMLMP=.): DEFINES += ENABLE_XHTMLMP=1 Irrespectively of this modification, you can use --xhtmlmp and --no-xhtmlmp to toggle XHTML-MP support.

Eric Seidel (no email)

Comment 8 2010-01-05 13:25:00 PST

Comment on attachment 45817 [details] Patch Assuming HTMLNoScriptElement is appropriately guarded, this looks fine. configure.ac looks insanely verbose and redundant. Your ChangeLogs need lovin before you can land this: + Need a short description and bug URL (OOPS!) + + No new tests. (OOPS!) +

Daniel Bates

Comment 9 2010-01-07 21:14:10 PST

(In reply to comment #8) > (From update of attachment 45817 [details]) > Assuming HTMLNoScriptElement is appropriately guarded, this looks fine. > > configure.ac looks insanely verbose and redundant. We should probably look to clean this up in a separate bug. > > Your ChangeLogs need lovin before you can land this: > + Need a short description and bug URL (OOPS!) > + > + No new tests. (OOPS!) > + Will change.

Daniel Bates

Comment 10 2010-01-07 22:16:55 PST

Committed r52972: <http://trac.webkit.org/changeset/52972>

Note You need to log in before you can comment on or make changes to this bug.