Bug 32979

Summary: [bzt] Create an ASAD command for uploading a patch
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2009-12-27 23:26:29 PST
[bzt] Create an ASAD commands for uploading a patch
Attachments
Patch (4.71 KB, patch)
2009-12-27 23:27 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.66 KB, patch)
2009-12-27 23:35 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (7.48 KB, patch)
2009-12-28 01:08 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-27 23:27:25 PST
Created attachment 45543 [details] Patch
Adam Barth
Comment 2 2009-12-27 23:27:58 PST
Comment on attachment 45543 [details] Patch Wow, that was strange. Let me try again.
Adam Barth
Comment 3 2009-12-27 23:35:22 PST
Created attachment 45544 [details] Patch
WebKit Review Bot
Comment 4 2009-12-27 23:36:58 PST
style-queue ran check-webkit-style on attachment 45544 [details] without any errors.
Eric Seidel (no email)
Comment 5 2009-12-27 23:57:43 PST
Comment on attachment 45544 [details] Patch Kill --editor, EDITOR= does the same thing. edit shoudl be on the user moduel anyway. What about interacting with --non-interactive? Can we detect that and error out? something like if "non-interactive" in options?
Adam Barth
Comment 6 2009-12-28 01:08:05 PST
Created attachment 45549 [details] Patch
WebKit Review Bot
Comment 7 2009-12-28 01:09:21 PST
style-queue ran check-webkit-style on attachment 45549 [details] without any errors.
Eric Seidel (no email)
Comment 8 2009-12-28 08:54:44 PST
Comment on attachment 45549 [details] Patch Seems like we'll want some new class for this: 190 diff = state.get("diff") 191 if not diff: 192 diff = self._tool.scm().create_patch() 193 state["diff"] = diff Maybe a CachingState? with a .diff() method? Or just a .get_cached_value("diff", self._tool.scm().create_patch) command? Glad to see you've abstracted it at least for this one command. Looks like an OK start.
WebKit Commit Bot
Comment 9 2009-12-28 09:06:44 PST
Comment on attachment 45549 [details] Patch Clearing flags on attachment: 45549 Committed r52599: <http://trac.webkit.org/changeset/52599>
WebKit Commit Bot
Comment 10 2009-12-28 09:06:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.