|Summary:||[bzt] Create an ASAD command for uploading a patch|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, eric, mjs, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Adam Barth 2009-12-27 23:26:29 PST
[bzt] Create an ASAD commands for uploading a patch
Comment 2 Adam Barth 2009-12-27 23:27:58 PST
Comment on attachment 45543 [details] Patch Wow, that was strange. Let me try again.
Comment 4 WebKit Review Bot 2009-12-27 23:36:58 PST
style-queue ran check-webkit-style on attachment 45544 [details] without any errors.
Comment 5 Eric Seidel (no email) 2009-12-27 23:57:43 PST
Comment on attachment 45544 [details] Patch Kill --editor, EDITOR= does the same thing. edit shoudl be on the user moduel anyway. What about interacting with --non-interactive? Can we detect that and error out? something like if "non-interactive" in options?
Comment 7 WebKit Review Bot 2009-12-28 01:09:21 PST
style-queue ran check-webkit-style on attachment 45549 [details] without any errors.
Comment 8 Eric Seidel (no email) 2009-12-28 08:54:44 PST
Comment on attachment 45549 [details] Patch Seems like we'll want some new class for this: 190 diff = state.get("diff") 191 if not diff: 192 diff = self._tool.scm().create_patch() 193 state["diff"] = diff Maybe a CachingState? with a .diff() method? Or just a .get_cached_value("diff", self._tool.scm().create_patch) command? Glad to see you've abstracted it at least for this one command. Looks like an OK start.
Comment 9 WebKit Commit Bot 2009-12-28 09:06:44 PST
Comment on attachment 45549 [details] Patch Clearing flags on attachment: 45549 Committed r52599: <http://trac.webkit.org/changeset/52599>
Comment 10 WebKit Commit Bot 2009-12-28 09:06:50 PST
All reviewed patches have been landed. Closing bug.