Bug 32965 – svn-apply should handle the bugid

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Patrick R. Gansterer]

When posting a patch to bugzilla you have to post it with the correct bugid.
svn-apply should replace e.g. https://bugs.webkit.org/show_bug.cgi?id=XXX with the correct url when found in a changelog file.

[Patrick R. Gansterer]

Created attachment 45528 [details]
The patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45528 [details] without any errors.

[Eric Seidel (no email)]

What does this look like in the end?

prepare-ChagneLog --bug already does this, no?  Why wouldn't we share code there?

I'm not even sure under what use case this makes sense...

[Patrick R. Gansterer]

(In reply to comment #3)
> I'm not even sure under what use case this makes sense...
Currently you first need to create a bug to get a bugid, then you can prepare changelog and then add it to the bug.
With this extension you can prepare all your bugs ("offline") and upload them without care to the bugid.

In #32963 i forgotten the change the bugid and this is a work which can be done by the bot.
It would be great if attachment 45525 [details] with "?id=XXX" also work and not only attachment 45527 [details] with "?id=32963".

[Adam Barth]

I'm a bit skeptical about this use case.  It seems like a better time to do this is when you're uploading the patch to the bug.  At that time, you know what the bug number is...  The most magical stuff we have in ChangeLogs, the more complex the system is and the harder it is to review patches.

[Patrick R. Gansterer]

(In reply to comment #5)
> I'm a bit skeptical about this use case.  It seems like a better time to do
> this is when you're uploading the patch to the bug.
Then you can't use the add attachment during creating the bug.

Maybe my workflow is "wrong", but i first change my files, then prepare the changelog, run svn-create-patch and remove the unrelevant stuff from the patch. Then i create a new bug, change the bugid and upload the patch.
The last step could become one.

In the moment there is no (automatic) check for the correct bugid too.

[Adam Barth]

You could try the following workflow:

1) Edit the code
2) ./WebKitTools/Scripts/bugzilla-tool prepare-diff
3) Edit the ChangeLog
4) ./WebKitTools/Script/bugzilla-tool post-diff

That will take care of creating the bug and filling in the bug number in the right place in the ChangeLog.  Once Bug 32979 is fixed, steps 2, 3, and 4 will be become "bugzilla-tool create-review".

Another thing we can do is make bugzilla-tool post-diff fill in the right bug URL before it posts the diff.  That would make it so reviewers don't need to know about more magical ChangeLog syntax.

[Adam Barth]

Comment on attachment 45528 [details]
The patch

I think we should move this idea to bugzilla-tool post-diff.  I'm not sure whether we should have magical syntax that post-diff knows about or whether it should just add the whole bug URL to ChangeLogs that are missing them.

[Eric Seidel (no email)]

This is covered by other workflows.