Summary: | [Qt] Missing SVG variables | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | SVG | Assignee: | Joe Wild <joseph.wild> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abecsi, commit-queue, hausmann, joseph.wild, kent.hansen, laszlo.gombos, yael, zimmermann | ||||
Priority: | P3 | Keywords: | LayoutTestFailure, Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2009-12-25 14:52:16 PST
http://trac.webkit.org/changeset/52560 - svg/custom/global-constructors.html skipped until fix. Platform dependent expected files updated after r52559 - platform/qt/fast/dom/Window/window-properties-expected.txt: updated. - platform/qt/fast/dom/prototype-inheritance-expected.txt: updated. - platform/qt/fast/js/global-constructors-expected.txt: updated. --- LayoutTests/fast/dom/prototype-inheritance-expected.txt +++ LayoutTests/platform/qt/fast/dom/prototype-inheritance-expected.txt Removed from platform independent expected files by http://trac.webkit.org/changeset/52513 (why?) +PASS inner.HTMLDataGridCellElement.isInner is true +PASS inner.HTMLDataGridCellElement.constructor.isInner is true +PASS inner.HTMLDataGridColElement.isInner is true +PASS inner.HTMLDataGridColElement.constructor.isInner is true +PASS inner.HTMLDataGridElement.isInner is true +PASS inner.HTMLDataGridElement.constructor.isInner is true After http://trac.webkit.org/changeset/52559 Qt-port doesn't dump these: -PASS inner.SVGAltGlyphElement.isInner is true -PASS inner.SVGAltGlyphElement.constructor.isInner is true -PASS inner.SVGAnimateColorElement.isInner is true -PASS inner.SVGAnimateColorElement.constructor.isInner is true -PASS inner.SVGAnimateElement.isInner is true -PASS inner.SVGAnimateElement.constructor.isInner is true -PASS inner.SVGAnimateTransformElement.isInner is true -PASS inner.SVGAnimateTransformElement.constructor.isInner is true -PASS inner.SVGFontElement.isInner is true -PASS inner.SVGFontElement.constructor.isInner is true -PASS inner.SVGFontFaceElement.isInner is true -PASS inner.SVGFontFaceElement.constructor.isInner is true -PASS inner.SVGFontFaceFormatElement.isInner is true -PASS inner.SVGFontFaceFormatElement.constructor.isInner is true -PASS inner.SVGFontFaceNameElement.isInner is true -PASS inner.SVGFontFaceNameElement.constructor.isInner is true -PASS inner.SVGFontFaceSrcElement.isInner is true -PASS inner.SVGFontFaceSrcElement.constructor.isInner is true -PASS inner.SVGFontFaceUriElement.isInner is true -PASS inner.SVGFontFaceUriElement.constructor.isInner is true -PASS inner.SVGForeignObjectElement.isInner is true -PASS inner.SVGForeignObjectElement.constructor.isInner is true -PASS inner.SVGGlyphElement.isInner is true -PASS inner.SVGGlyphElement.constructor.isInner is true -PASS inner.SVGMissingGlyphElement.isInner is true -PASS inner.SVGMissingGlyphElement.constructor.isInner is true -PASS inner.SVGSetElement.isInner is true -PASS inner.SVGSetElement.constructor.isInner is true Only Qt port support TouchEvent now: +PASS inner.TouchEvent.isInner is true +PASS inner.TouchEvent.constructor.isInner is true What's the status of this? The test in question - svg/custom/global-constructors.html is still skipped, so this is a valid issue AFAICS. Changed component to SVG, so it shows up in my all-svg-bugs search. I have been looking at this one. Please assign it to me. It looks like we were not passing on all the ENABLE_SVG_* flags to the IDL compiler, so some of the binding were not generated. I added passing on the rest of the ENABLE_SVG_* flags and need to test if that fixes the problem. Source/WebCore/feature.pri contains(DEFINES, ENABLE_SVG=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG=1 + contains(DEFINES, ENABLE_SVG_ANIMATION=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_ANIMATION=1 + contains(DEFINES, ENABLE_SVG_FONTS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_FONTS=1 + contains(DEFINES, ENABLE_SVG_FOREIGN_OBJECT=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_FOREIGN_OBJECT=1 (In reply to comment #6) Thanks for looking into this bug. I tested your idea, and it works for me ;) Please upload a patch with ChangeLog entry, unskip svg/custom/global-constructors.html and update these Qt specific expected files: - platform/qt/fast/dom/Window/window-properties-expected.txt - platform/qt/fast/dom/Window/window-property-descriptors-expected.txt - platform/qt/fast/dom/prototype-inheritance-expected.txt - platform/qt/fast/js/global-constructors-expected.txt And then I will review your patch. Created attachment 85081 [details]
For Qt Build, pass on the ENABLE_SVG_* flags to the IDL binding generator.
Basically, this patch just modifies features.pri to the Qt build to
pass on the ENABLE_SVG_* flags to the IDL binding generator.
Also I had remove global-construtors.html from the skip list and
updated the associated expected results files.
Comment on attachment 85081 [details]
For Qt Build, pass on the ENABLE_SVG_* flags to the IDL binding generator.
LGTM, r=me. Thanks for the fix.
Comment on attachment 85081 [details] For Qt Build, pass on the ENABLE_SVG_* flags to the IDL binding generator. Clearing flags on attachment: 85081 Committed r80587: <http://trac.webkit.org/changeset/80587> All reviewed patches have been landed. Closing bug. |