Bug 32932

Summary:

Web Inspector: Fix UI issues in the Audits panel

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Suggested fix	none
[IMAGE] Audit Result View with the fixed UI	none
[PATCH] Review followed	none

Alexander Pavlov (apavlov)

Reported 2009-12-25 02:06:45 PST

- There should be no double borders (left and bottom sides of the AuditResultView) - Results should be expanded only one level initially (AuditResultView) - All audits should be enabled by default (AuditLauncherView)

Attachments
[PATCH] Suggested fix (8.61 KB, patch) 2009-12-25 07:58 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
[IMAGE] Audit Result View with the fixed UI (68.54 KB, image/png) 2009-12-25 08:12 PST, Alexander Pavlov (apavlov)	no flags	Details
[PATCH] Review followed (8.54 KB, patch) 2009-12-28 06:29 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2009-12-25 07:58:15 PST

Created attachment 45490 [details] [PATCH] Suggested fix

WebKit Review Bot

Comment 2 2009-12-25 08:02:07 PST

style-queue ran check-webkit-style on attachment 45490 [details] without any errors.

Alexander Pavlov (apavlov)

Comment 3 2009-12-25 08:12:33 PST

Created attachment 45491 [details] [IMAGE] Audit Result View with the fixed UI No double borders on the left and bottom, the results are not expanded more than 1 level initially.

Alexander Pavlov (apavlov)

Comment 4 2009-12-28 06:29:41 PST

Created attachment 45551 [details] [PATCH] Review followed

WebKit Review Bot

Comment 5 2009-12-28 06:33:12 PST

style-queue ran check-webkit-style on attachment 45551 [details] without any errors.

Pavel Feldman

Comment 6 2009-12-29 11:47:07 PST

Once initial audit set is in, we will need to send screens to Timothy for designing the real ui.

WebKit Commit Bot

Comment 7 2009-12-29 11:56:10 PST

Comment on attachment 45551 [details] [PATCH] Review followed Clearing flags on attachment: 45551 Committed r52629: <http://trac.webkit.org/changeset/52629>

WebKit Commit Bot

Comment 8 2009-12-29 11:56:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.