Summary: | With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | HTML Editing | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
URL: | http://google.com | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2009-12-23 10:35:15 PST
Created attachment 45444 [details]
proposed fix
style-queue ran check-webkit-style on attachment 45444 [details] without any errors.
Comment on attachment 45444 [details] proposed fix > + // An open typing command that disagrees about current selection would cause issues with typing later on. > + if (m_lastEditCommand && m_lastEditCommand->isTypingCommand()) > + static_cast<TypingCommand*>(m_lastEditCommand.get())->closeTyping(); I think this needs to check isOpenForMoreTyping before just calling closeTyping. Luckily there is a helper function for this. You should just write: TypingCommand::closeTyping(m_lastEditCommand); The class member function handles the null check too. r=me if you change it like I suggest > I think this needs to check isOpenForMoreTyping before just calling > closeTyping. I wonder why - closeTyping() just sets a boolean member value. > r=me if you change it like I suggest I'll make the change, if only for consistency. (In reply to comment #4) > > I think this needs to check isOpenForMoreTyping before just calling > > closeTyping. > > I wonder why - closeTyping() just sets a boolean member value. Guess you're right. Wonder why TypingCommand::closeTyping bothers to check it! Committed <http://trac.webkit.org/changeset/52542>. |