Bug 32892
| Summary: | Exception running commit-queue in an svn checkout | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, dbates, ddkilzer, mjs |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
Exception running commit-queue in an svn checkout
I expect that I just don't have the keychain setup correctly.
Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue...
Traceback (most recent call last):
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/queueengine.py", line 111, in run
self._delegate.handle_unexpected_error(work_item, message)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/commands/queues.py", line 163, in handle_unexpected_error
self.tool.bugs.reject_patch_from_commit_queue(patch["id"], message)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 443, in reject_patch_from_commit_queue
self._set_flag_on_attachment(attachment_id, 'commit-queue', '-', comment_text, additional_comment_text)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 426, in _set_flag_on_attachment
self.authenticate()
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/bugzilla.py", line 303, in authenticate
(username, password) = Credentials(self.bug_server_host, git_prefix="bugzilla").read_credentials()
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/credentials.py", line 84, in read_credentials
(username, password) = self._credentials_from_keychain(username)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/credentials.py", line 77, in _credentials_from_keychain
security_output = self._run_security_tool(username)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/credentials.py", line 71, in _run_security_tool
return self.executive.run_command(security_command)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/executive.py", line 127, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/Users/eseidel/Projects/CommitQueueSVN/WebKitTools/Scripts/modules/executive.py", line 104, in default_error_handler
raise error
ScriptError: Failed to run "['/usr/bin/security', 'find-internet-password', '-g', '-s', 'bugs.webkit.org']" exit_code: 44
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I've fixed the commit-queue instance I have running by configuring the keychain correctly. However, the queue should know how to handle this better in the future. We should probably exit with instructions as to how to set up the keychain when in --non-interactive mode like this, and in normal interactive mode, we should probably prompt for the username/pass and save them in the keychain. :)
Daniel Bates
*** This bug has been marked as a duplicate of bug 33039 ***