Summary: | [V8] NodeList should support call as function | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Johnny(Jianning) Ding <jnd> | ||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Johnny(Jianning) Ding
2009-12-22 02:19:15 PST
Created attachment 45465 [details]
patch to fix this issue
Implemented the V8NodeList::callAsFunctionCallback by referring callNodeList in JSNodeListCustom.cpp
style-queue ran check-webkit-style on attachment 45465 [details] without any errors.
Attachment 45465 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/142726 Comment on attachment 45465 [details] patch to fix this issue Seems this should be a real script-test (i.e. the html should just be autogenerated): http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree dglazkov is probably your best reviwer here. (In reply to comment #3) > Attachment 45465 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/142726 Any thoughts on this build failure? Is this a mistake in the patch or a mistake by the bot? (In reply to comment #4) > (From update of attachment 45465 [details]) > Seems this should be a real script-test (i.e. the html should just be > autogenerated): > http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree > > dglazkov is probably your best reviwer here. Done, Thx and Merry XMas! (In reply to comment #5) > (In reply to comment #3) > > Attachment 45465 [details] [details] did not build on chromium: > > Build output: http://webkit-commit-queue.appspot.com/results/142726 > > Any thoughts on this build failure? Is this a mistake in the patch or a > mistake by the bot? My mistake, miss the .pm file. A new patch will be uploaded soon. Created attachment 45487 [details]
patch v2 to fix this issue.
Attachment 45487 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8DOMWrapper.cpp:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1
Created attachment 45488 [details]
patch v2 to fix this issue.
Created attachment 45489 [details]
patch v2 to fix this issue
style-queue ran check-webkit-style on attachment 45489 [details] without any errors.
Comment on attachment 45489 [details]
patch v2 to fix this issue
great, thanks! Are you sure there wasn't already a test for this?
Comment on attachment 45489 [details] patch v2 to fix this issue Rejecting patch 45489 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueueSVN/LayoutTests Testing 11854 test cases. fast/css/non-standard-checkbox-size.html -> failed Exiting early after 1 failures. 5218 tests run. 79.16s total testing time 5217 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/150773 Comment on attachment 45489 [details] patch v2 to fix this issue Sorry. We were bit by bug 28603. I've fixed the commit bot for now. Comment on attachment 45489 [details] patch v2 to fix this issue Clearing flags on attachment: 45489 Committed r52627: <http://trac.webkit.org/changeset/52627> All reviewed patches have been landed. Closing bug. |