Summary: | Background image positioning on RTL text | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Vella <david.vella> | ||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | abarth, commit-queue, eric, mitz, webkit.review.bot, xji, yael | ||||||||
Priority: | P3 | Keywords: | HasReduction | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://extdev.bbc.co.uk/worldservice/testcases/webkit_background_image.shtml | ||||||||||
Attachments: |
|
Description
David Vella
2009-12-22 02:04:40 PST
Created attachment 51844 [details] WebArchive of http://extdev.bbc.co.uk/.../webkit_background_image.shtml For the purpose of preservation, a WebArchive of the reduction <http://extdev.bbc.co.uk/worldservice/testcases/webkit_background_image.shtml> Created attachment 82184 [details]
Patch.
When the style of InlineFlowBox is right-to-left, the strips should be re-arranged in reverse oreder.
Please note that the code change is very small and the patch is big due to the tests :)
Sorry, one test is missing, I'll update the patch soon. Comment on attachment 82184 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=82184&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:1012 > + int totalLogicalWidth = 0; No reason to initialize this to zero. It’s set in all code paths below. Created attachment 82196 [details]
Patch.
Removed un-needed initializer and added the missing test.
Comment on attachment 82196 [details] Patch. Clearing flags on attachment: 82196 Committed r78396: <http://trac.webkit.org/changeset/78396> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/78396 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: fast/loader/empty-embed-src-attribute.html |