Bug 32857 – RVCT (__ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Kwang Yul Seo]

RVCT 4.0 provides strcasecmp and strncasemp as C library extensions, but earlier versions of RVCT do not provide these functions.

We can check this from RVCT manual pages:

RealView® Compilation Tools Libraries and Floating Point Support Guide
Version 4.0

http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0349b/index.html

RealView ® CompilationTools Libraries and Floating Point Support Guide
Version 3.1

http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0349a/index.html


Theses functions needs to be implemented in StringExtras.h and StringExtras.cpp for RVCT < 4.0

[Kwang Yul Seo]

Created attachment 45372 [details]
Add strcasecmp and strncasecmp for RVCT < 4.0

[WebKit Review Bot]

Attachment 45372 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/StringExtras.cpp:56:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1

[Kwang Yul Seo]

Created attachment 45376 [details]
Fix the style error.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45376 [details] without any errors.

[Darin Adler]

Comment on attachment 45376 [details]
Fix the style error.

This patch is OK, but I'd prefer to see us eliminate strcasecmp and strncasecmp from the code instead.

These compare non-ASCII characters without any processing, which is better for our purposes, whereas strcasecmp and strncasecmp may handle non-ASCII characters as letters based on the current POSIX locale setting.

It'd be good to provide an ASCII version of strcasecmp and strncasecmp and get rid of the current uses of them.

[WebKit Commit Bot]

Comment on attachment 45376 [details]
Fix the style error.

Clearing flags on attachment: 45376

Committed r52493: <http://trac.webkit.org/changeset/52493>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.