Bug 32854

Summary:

Remove COM code generation related files

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

WebKit API

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, dglazkov, eric, mjs, sam, sfalken, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Bug Depends on:

33190, 33193

Bug Blocks:

Attachments:

Description	Flags
Proposed patch	none
Proposed patch (rev.2)	sam: review-
Proposed patch (rev.3)	mjs: review+, tkent: commit-queue-

Description Kent Tamura 2009-12-22 00:06:43 PST

We won't support COM code generation anymore. There are some files related to it in WebKit repository yet.

Comment 1 Kent Tamura 2009-12-22 00:08:30 PST

Created attachment 45368 [details]
Proposed patch

Comment 2 WebKit Review Bot 2009-12-22 00:11:16 PST

style-queue ran check-webkit-style on attachment 45368 [details] without any errors.

Comment 3 Kent Tamura 2009-12-22 01:16:09 PST

Created attachment 45373 [details]
Proposed patch (rev.2)

Remove !LANGUAGE_COM in *.idl too.

Comment 4 WebKit Review Bot 2009-12-22 01:17:50 PST

style-queue ran check-webkit-style on attachment 45373 [details] without any errors.

Comment 5 Eric Seidel (no email) 2009-12-22 12:59:14 PST

This is definitely one for the Apple-Win folks to review.

Comment 6 Maciej Stachowiak 2009-12-28 17:54:00 PST

Perhaps Adam, Steve or Sam want to comment on whether it's ok to strip this code out entirely or if we want to keep it around for some reason.

Comment 7 Sam Weinig 2009-12-30 15:19:23 PST

Comment on attachment 45373 [details]
Proposed patch (rev.2)

It is fine to rip this out, we can always bring it back through the magic of svn.  That said, you are missing some COM specific things, namely the InterfaceUUID and ImplementationUUID extended attributes.  Those should be removed as well.

Comment 8 Kent Tamura 2010-01-04 13:27:09 PST

Created attachment 45825 [details]
Proposed patch (rev.3)

- Remove UUID attributes in *.idl too.

Comment 9 WebKit Review Bot 2010-01-04 13:29:49 PST

Attachment 45825 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/162587

Comment 10 WebKit Review Bot 2010-01-04 13:30:39 PST

style-queue ran check-webkit-style on attachment 45825 [details] without any errors.

Comment 11 Eric Seidel (no email) 2010-01-05 13:54:44 PST

Comment on attachment 45825 [details]
Proposed patch (rev.3)

Is WebKit/win/WebKit.vcproj/build-generated-files.sh only used by the COM bindings?

The rest all looks fine.

Comment 12 Maciej Stachowiak 2010-01-05 14:11:45 PST

Comment on attachment 45825 [details]
Proposed patch (rev.3)

Looks like this addresses Sam's comments. I believe the answer to Eric's question is "yes". r=me

Comment 13 Eric Seidel (no email) 2010-01-06 09:30:09 PST

Attachment 45825 [details] was posted by a committer and has review+, assigning to Kent Tamura for commit.

Comment 14 Kent Tamura 2010-01-07 05:47:08 PST

Landed as r52921 <http://trac.webkit.org/changeset/52921>