Summary: | [check-webkit-style] qt unit testing false positives | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | carol, commit-queue, kenneth, laszlo.gombos, levin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 33771 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adam Barth
2009-12-21 12:04:04 PST
The fundamental issue here is whether API tests - that are not part of WebKit binary per say - needs to also follow the WebKit style or not. It might make sense not to expose WebKit style guide for API tests. (In reply to comment #1) > The fundamental issue here is whether API tests - that are not part of WebKit > binary per say - needs to also follow the WebKit style or not. It might make > sense not to expose WebKit style guide for API tests. I think it would be better to disable some of the tests for certain subdirs, such as WebKit/qt/Api Created attachment 46769 [details]
Patch (requires blocking bug to be fixed)
Comment on attachment 46769 [details] Patch (requires blocking bug to be fixed) Clearing flags on attachment: 46769 Committed r53386: <http://trac.webkit.org/changeset/53386> All reviewed patches have been landed. Closing bug. |