Summary: | types must match on ?: in css/CSSComputedStyleDeclaration.cpp | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ben Taylor <bentaylor.solx86> |
Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Other | ||
Attachments: |
Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>? (In reply to comment #1) > Would you be willing to submit a patch for review, as described in > <http://webkit.org/coding/contributing.html>? Someone who actually knows something about the application might be better to check the very small patch I submitted. I'm just trying to get QT compiled. I don't know when I'll have the port complete. Created attachment 85472 [details]
Updated version of the patch to more correctly represent a "0" (as previously used in the conditional) to a type acceptable by the SS12 compiler
This is an updated patch that fixes a webkit component to compile on Solaris 10 with the SunStudio12 compiler.
Simply, a 0 (int) causes a problem for strongly typed SunStudio 12 C++ and this patch uses a more normalized form of an "empty" pointer so that the compilation will continue.
I'm sorry to sound like a broken record, but please do follow <http://webkit.org/coding/contributing.html> to contribute code. In particular, the patch lacks a ChangeLog, and doesn't have r? bit set for review. Without a ChangeLog, the patch cannot be landed, and without being marked for review, it isn't visible in review queue. Created attachment 85593 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This fix is against webkit head, but works for the webkit distributed with qt-4.7.1. This fix is similar to the one in https://bugs.webkit.org/attachment.cgi?bugid=56198 which passed muster. Comment on attachment 85593 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler
Thank you!
Comment on attachment 85593 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85593 Committed r81869: <http://trac.webkit.org/changeset/81869> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/81869 might have broken GTK Linux 64-bit Debug The following tests are not passing: loader/reload-subresource-when-type-changes.html |
Created attachment 45325 [details] Patch to fix the problem with the conflicting types. compiling qt-4.6.0 with webkit on Solaris 10 with Studio 12, I see the following error: "css/CSSComputedStyleDeclaration.cpp", line 570: Error: Ambiguous "?:"expression, second operand of type "int" and third operand of type "WTF::PassRefPtr<WebCore::CSSPrimitiveValue>" can be converted to one another. "css/CSSComputedStyleDeclaration.cpp", line 571: Error: Ambiguous "?:"expression, second operand of type "int" and third operand of type "WTF::PassRefPtr<WebCore::CSSPrimitiveValue>" can be converted to one another. I've submitted a patch which has passed compilation.