Bug 32812 – Exception on queue status server

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

http://webkit-commit-queue.appspot.com/patch/45306

Traceback (most recent call last):
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/__init__.py", line 507, in __call__
    handler.get(*groups)
  File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/handlers/patch.py", line 53, in get
    self.response.out.write(template.render("templates/patch.html", template_values))
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 81, in render
    return t.render(Context(template_dict))
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 121, in wrap_render
    return orig_render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 178, in render
    return self.nodelist.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render
    bits.append(self.render_node(node, context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node
    return node.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render
    nodelist.append(node.render(context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render
    nodelist.append(node.render(context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 243, in render
    return self.nodelist_true.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render
    bits.append(self.render_node(node, context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node
    return node.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 826, in render
    output = self.filter_expression.resolve(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 572, in resolve
    new_obj = func(obj, *arg_vals)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaultfilters.py", line 40, in _dec
    return func(*args, **kwargs)
  File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/filters/webkit_extras.py", line 59, in results_link
    return '<a href="/results/' + status.key().id() + '">results</a>'
AttributeError: 'unicode' object has no attribute 'key'

[Adam Barth]

Created attachment 45311 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 45311 [details]
Patch

 59     return '<a href="/results/' + status_id + '">results</a>'

should really use % instead of +

Otherwise LGTM.

[Adam Barth]

Created attachment 45312 [details]
Patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45312 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 45312 [details]
Patch

LGTM.

Eventually we need to come up with unit tests for this side of things too. :)  Maybe just doctests.

[WebKit Commit Bot]

Comment on attachment 45312 [details]
Patch

Clearing flags on attachment: 45312

Committed r52437: <http://trac.webkit.org/changeset/52437>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.