Bug 32812

Summary: Exception on queue status server
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Eric Seidel (no email) 2009-12-20 22:32:44 PST
http://webkit-commit-queue.appspot.com/patch/45306

Traceback (most recent call last):
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/__init__.py", line 507, in __call__
    handler.get(*groups)
  File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/handlers/patch.py", line 53, in get
    self.response.out.write(template.render("templates/patch.html", template_values))
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 81, in render
    return t.render(Context(template_dict))
  File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 121, in wrap_render
    return orig_render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 178, in render
    return self.nodelist.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render
    bits.append(self.render_node(node, context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node
    return node.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render
    nodelist.append(node.render(context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render
    nodelist.append(node.render(context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 243, in render
    return self.nodelist_true.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render
    bits.append(self.render_node(node, context))
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node
    return node.render(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 826, in render
    output = self.filter_expression.resolve(context)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 572, in resolve
    new_obj = func(obj, *arg_vals)
  File "/base/python_lib/versions/third_party/django-1.1/django/template/defaultfilters.py", line 40, in _dec
    return func(*args, **kwargs)
  File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/filters/webkit_extras.py", line 59, in results_link
    return '<a href="/results/' + status.key().id() + '">results</a>'
AttributeError: 'unicode' object has no attribute 'key'
Comment 1 Adam Barth 2009-12-21 00:48:48 PST
Created attachment 45311 [details]
Patch
Comment 2 Eric Seidel (no email) 2009-12-21 00:50:11 PST
Comment on attachment 45311 [details]
Patch

 59     return '<a href="/results/' + status_id + '">results</a>'

should really use % instead of +

Otherwise LGTM.
Comment 3 Adam Barth 2009-12-21 00:54:54 PST
Created attachment 45312 [details]
Patch
Comment 4 WebKit Review Bot 2009-12-21 00:55:58 PST
style-queue ran check-webkit-style on attachment 45312 [details] without any errors.
Comment 5 Eric Seidel (no email) 2009-12-21 00:57:03 PST
Comment on attachment 45312 [details]
Patch

LGTM.

Eventually we need to come up with unit tests for this side of things too. :)  Maybe just doctests.
Comment 6 WebKit Commit Bot 2009-12-21 01:07:45 PST
Comment on attachment 45312 [details]
Patch

Clearing flags on attachment: 45312

Committed r52437: <http://trac.webkit.org/changeset/52437>
Comment 7 WebKit Commit Bot 2009-12-21 01:07:51 PST
All reviewed patches have been landed.  Closing bug.