Summary: | [WML] Compilation errors in WML enabled build. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nayan <nayankk> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Nayan
2009-12-20 03:24:09 PST
Created attachment 45267 [details]
Fix for compilation errors
Proposed patch for resolving compilation errors is attached.
Attachment 45267 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/wml/WMLPageState.cpp:31: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/wml/WMLDocument.cpp:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2
Comment on attachment 45267 [details]
Fix for compilation errors
Please add these headers in alphabetical order.
Created attachment 45284 [details]
Compilation error fix.
Proper fix taking care of review-bot output.
style-queue ran check-webkit-style on attachment 45284 [details] without any errors.
Comment on attachment 45284 [details] Compilation error fix. Clearing flags on attachment: 45284 Committed r52431: <http://trac.webkit.org/changeset/52431> All reviewed patches have been landed. Closing bug. |