Bug 32768

Summary: Split QueueStatus server into modules
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, evan, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2009-12-18 23:04:44 PST 
One monolithic file is no good.
Comment 1 Adam Barth 2009-12-18 23:05:29 PST 
Created attachment 45225 [details]
Patch
Comment 2 WebKit Review Bot 2009-12-18 23:06:20 PST 
style-queue ran check-webkit-style on attachment 45225 [details] without any errors.
Comment 3 Eric Seidel (no email) 2009-12-18 23:11:16 PST 
Comment on attachment 45225 [details]
Patch

I dont' really know the patterns to comment.  This looks better than what we had.
Comment 4 Evan Martin 2009-12-19 04:02:57 PST 
This would be easier to review if you made each file a derivative of the original file.  Hard to convince git to do this.  One way is
a) cp origin-file new-file1; cp origin-file new-file2; etc.  git add, commit -a, svn dcommit.
b) now do your edits and let us review the patch.

This LGTM though.
Comment 5 Eric Seidel (no email) 2009-12-28 22:40:55 PST 
Attachment 45225 [details] was posted by a committer and has review+, assigning to Adam Barth for commit.
Comment 6 Eric Seidel (no email) 2009-12-28 23:41:07 PST 
Looks like this was already landed as bug 52381.  Silly Adam. ;)
Comment 7 Eric Seidel (no email) 2009-12-28 23:41:20 PST 
I meant landed as r52381.