Bug 32768

Summary: Split QueueStatus server into modules
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, evan, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2009-12-18 23:04:44 PST
One monolithic file is no good.
Attachments
Patch (27.42 KB, patch)
2009-12-18 23:05 PST, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-18 23:05:29 PST
Created attachment 45225 [details] Patch
WebKit Review Bot
Comment 2 2009-12-18 23:06:20 PST
style-queue ran check-webkit-style on attachment 45225 [details] without any errors.
Eric Seidel (no email)
Comment 3 2009-12-18 23:11:16 PST
Comment on attachment 45225 [details] Patch I dont' really know the patterns to comment. This looks better than what we had.
Evan Martin
Comment 4 2009-12-19 04:02:57 PST
This would be easier to review if you made each file a derivative of the original file. Hard to convince git to do this. One way is a) cp origin-file new-file1; cp origin-file new-file2; etc. git add, commit -a, svn dcommit. b) now do your edits and let us review the patch. This LGTM though.
Eric Seidel (no email)
Comment 5 2009-12-28 22:40:55 PST
Attachment 45225 [details] was posted by a committer and has review+, assigning to Adam Barth for commit.
Eric Seidel (no email)
Comment 6 2009-12-28 23:41:07 PST
Looks like this was already landed as bug 52381. Silly Adam. ;)
Eric Seidel (no email)
Comment 7 2009-12-28 23:41:20 PST
I meant landed as r52381.
Note You need to log in before you can comment on or make changes to this bug.