Bug 32757

Summary:

Repaint bug with -webkit-shadow on svg shapes

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

SVG

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, krit, simon.fraser, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Reduction	none
Patch	bdakin: review-
New patch	none
Even newer patch	oliver: review+

Beth Dakin

Reported 2009-12-18 16:43:04 PST

Created attachment 45210 [details] Reduction Dragging around the shapes in the attached test cases leaves behind traces of the shadow. <rdar://problem/7389149>

Attachments
Reduction (2.23 KB, text/html) 2009-12-18 16:43 PST, Beth Dakin	no flags	Details
Patch (3.13 KB, patch) 2009-12-18 16:50 PST, Beth Dakin	bdakin: review-	Details Formatted Diff Diff
New patch (17.80 KB, patch) 2010-01-07 16:40 PST, Beth Dakin	no flags	Details Formatted Diff Diff
Even newer patch (18.87 KB, patch) 2010-01-08 15:23 PST, Beth Dakin	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2009-12-18 16:44:28 PST

I have a patch that I will attach momentarily.

Beth Dakin

Comment 2 2009-12-18 16:50:18 PST

Created attachment 45211 [details] Patch I'm not sure how to write a test for this, but I am open to suggestions!

WebKit Review Bot

Comment 3 2009-12-18 16:54:26 PST

style-queue ran check-webkit-style on attachment 45211 [details] without any errors.

Simon Fraser (smfr)

Comment 4 2009-12-18 16:57:31 PST

You should be able to write a repaint test that moves an SVG object in JS.

Beth Dakin

Comment 5 2009-12-18 17:04:07 PST

Comment on attachment 45211 [details] Patch R-minusing this for now. This solution needs to be expanded beyond the root.

Dirk Schulze

Comment 6 2009-12-19 11:49:35 PST

This does not only happen on shadows. I can reproduce it without shadows and the same example. But only for the star, where the stroke is not drawn at the edge. We also need a general fix for repaintRectInLocalCoordinates independent of the bug for shadow.

Beth Dakin

Comment 7 2010-01-07 16:40:14 PST

Created attachment 46098 [details] New patch Here's a new patch that applies to more than just the root and also includes tests. Unfortunately, it does not fix the non-shadow bug that Dirk pointed out. I was able to reproduce that as well, and I spent some time working on a patch to fix both at once. Ultimately, it seems like it is just a separate bug. In the no-shadow case, I think that strokeBoundingBox() might be buggy, but I haven't worked out the details yet. I will file a new bug for that repaint issue.

Beth Dakin

Comment 8 2010-01-08 15:23:55 PST

Created attachment 46168 [details] Even newer patch Here's a better patch based on comments from Oliver and Dan on irc. This patch rewrites inflateForShadow to be more like RenderStyle::getBoxShadowExtent().

Oliver Hunt

Comment 9 2010-01-08 15:26:44 PST

Comment on attachment 46168 [details] Even newer patch r=me

Sam Weinig

Comment 10 2010-01-08 15:28:19 PST

Comment on attachment 46168 [details] Even newer patch > +static void getSVGShadowExtent(ShadowData* shadow, int &top, int &right, int &bottom, int &left) > +{ The & is on the wrong side here.

Beth Dakin

Comment 11 2010-01-08 15:37:45 PST

Good eye, Sammy, good eye. I fixed that before I checked in. http://trac.webkit.org/changeset/53017

Beth Dakin

Comment 12 2010-01-08 15:52:34 PST

I filed https://bugs.webkit.org/show_bug.cgi?id=33406 for the bug that Dirk found.

Note You need to log in before you can comment on or make changes to this bug.