Bug 32728
| Summary: | webkit-patch needs better credential handling | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | abarth, dbates, ddkilzer, dpranke |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 32635, 33039 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
bugzilla-tool needs better credential handling
I believe that the "ask for password/username" stuff broke when I re-wrote credentials.py recently.
Also Dirk pointed out that he has no idea how to add something to the keychain. bugzilla-tool needs to be fixed to know how to ask for passwords. It should probably also know how to store them in the keychain for you, but that's probably a separate bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
http://pypi.python.org/pypi/keyring looks very useful. I wonder if we could either auto-download that, or require people to install it if they want keychain support...
Eric Seidel (no email)
autoinstall support landed as part of bug 32635 and can now be easily used for things like keyring if desired:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/__init__.py
The "ask for password/username" stuff has been fixed by Dan Bates in bug 33039.
Eric Seidel (no email)
This has been fixed in later bugs.