Bug 32713

Summary: [Qt] make wtf/Assertions.h compile in winscw compiler.
Product: WebKit Reporter: Yongjun Zhang <yongjun.zhang>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
adding arg string before ellipsis to fix the issue. none

Description Yongjun Zhang 2009-12-18 07:45:52 PST
In wtf/Assertion.h, for variadic macro like ASSERT_WITH_MESSAGE(assertion, ...), winscw compiler doesn't recognize ellipsis alone in the macro definition; adding string arg before ellipsis make it compile fine.
Comment 1 Yongjun Zhang 2009-12-18 07:59:14 PST
Created attachment 45151 [details]
adding arg string before ellipsis to fix the issue.
Comment 2 WebKit Review Bot 2009-12-18 08:01:25 PST
style-queue ran check-webkit-style on attachment 45151 [details] without any errors.
Comment 3 Simon Hausmann 2009-12-18 08:23:07 PST
Comment on attachment 45151 [details]
adding arg string before ellipsis to fix the issue.

r=me
Comment 4 WebKit Commit Bot 2009-12-18 13:18:23 PST
Comment on attachment 45151 [details]
adding arg string before ellipsis to fix the issue.

Clearing flags on attachment: 45151

Committed r52337: <http://trac.webkit.org/changeset/52337>
Comment 5 WebKit Commit Bot 2009-12-18 13:18:27 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Hausmann 2009-12-30 01:19:05 PST
It turns out that this patch breaks the rvct release build: WebCore\loader\documentloader.cpp", line 793: Error:  #135: class "WebCore::String" has no member "ascii"

I'm investigating
Comment 7 Simon Hausmann 2009-12-30 01:47:37 PST
Sorry, false alarm. I merged this fix incorrectly (fixed now in c07df5686b431aa5d11643d00308d8f8f59d88b1 )