Summary: | [gtk] Make paths relocatable on runtime | ||
---|---|---|---|
Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, darin, eric, pnormand |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Attachments: |
Description
Fridrich Strba
2009-12-18 06:18:38 PST
Created attachment 49887 [details]
Patch doing what was described before
Created attachment 50013 [details]
Patch that does what the previous one, but does not leak memory.
Created attachment 50027 [details]
Patch modified not to use String::format
Comment on attachment 50027 [details] Patch modified not to use String::format I don't know if that is the best thing to do, but it seems to make sense and it has no impact on UNIX for WebKitGTK+ and we don't seem to leak memory. > +static char * > +get_webkit_datadir(void) I think this is a small style violation, but I see that we copy the code from other places. Comment on attachment 50027 [details] Patch modified not to use String::format Clearing flags on attachment: 50027 Committed r55531: <http://trac.webkit.org/changeset/55531> All reviewed patches have been landed. Closing bug. Created attachment 50033 [details]
Patch fixing a forgetful mind
Comment on attachment 50033 [details]
Patch fixing a forgetful mind
ooops.
reopening so that it can land Comment on attachment 50033 [details] Patch fixing a forgetful mind Rejecting patch 50033 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Holger Freyther', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/graphics/gtk/ImageGtk.cpp Hunk #1 FAILED at 159. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/graphics/gtk/ImageGtk.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/331689 Looks like this patch will need an update. The fix landed as a part of other patch, closing this bug |