Summary: | HTMLInputElement::valueAsNumber support | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bweinstein, darin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasnumber | ||||||
Bug Depends on: | 32697 | ||||||
Bug Blocks: | 19264, 29070, 30847, 34200, 34240 | ||||||
Attachments: |
|
Description
Kent Tamura
2009-12-17 22:03:26 PST
Created attachment 47393 [details]
Proposed patch
Add Darin to cc, who reviewed all of patches for valueAsDate. valueAsDate is very related to valueAsNumber. Comment on attachment 47393 [details] Proposed patch > + const double nan = std::numeric_limits<double>::quiet_NaN(); Normally we omit the "std" for things like this, and have "using namespace std" at the top of the file. r=me (In reply to comment #3) > (From update of attachment 47393 [details]) > > + const double nan = std::numeric_limits<double>::quiet_NaN(); > > Normally we omit the "std" for things like this, and have "using namespace std" > at the top of the file. Removed std::, and landed as r53893. This test failed on Windows since it was created. Landed expected failing results for Windows in r53959. (In reply to comment #5) > This test failed on Windows since it was created. Landed expected failing > results for Windows in r53959. I'll investigate it today. (In reply to comment #6) > (In reply to comment #5) > > This test failed on Windows since it was created. Landed expected failing > > results for Windows in r53959. > > I'll investigate it today. I made a bug entry for the failure: Bug#34240. |