Bug 32693

Summary: upstream fast/text/fake-italic.html
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: CSSAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch w/ test and mac baselines
none
first rev
none
add changelog msg
none
remove duplicate Changelog entries
none
add test for emulating italic when there are no italic versions of a glyph none

Description Dirk Pranke 2009-12-17 19:07:51 PST
Upstreaming fast/text/fake-italic.html from chromium.org - this tests synthesizing a slanted/italic effect on fonts that don't have a true italic glyph.
Comment 1 Dirk Pranke 2009-12-17 19:10:03 PST
Created attachment 45120 [details]
patch w/ test and mac baselines
Comment 2 Dirk Pranke 2009-12-17 19:11:34 PST
Comment on attachment 45120 [details]
patch w/ test and mac baselines

hmm .. not sure if 'git diff' handled the .png properly :(
Comment 3 mitz 2009-12-17 20:08:54 PST
(In reply to comment #2)
> (From update of attachment 45120 [details])
> hmm .. not sure if 'git diff' handled the .png properly :(

No, the PNG data is missing from the patch so it can’t be landed.
Comment 4 Dirk Pranke 2009-12-18 12:02:24 PST
Created attachment 45167 [details]
first rev
Comment 5 Dirk Pranke 2009-12-18 12:02:27 PST
Created attachment 45168 [details]
add changelog msg
Comment 6 Dirk Pranke 2009-12-18 12:02:30 PST
Created attachment 45169 [details]
remove duplicate Changelog entries
Comment 7 Dirk Pranke 2009-12-18 12:15:17 PST
Created attachment 45171 [details]
add test for emulating italic when there are no italic versions of a glyph
Comment 8 WebKit Review Bot 2009-12-18 12:17:55 PST
style-queue ran check-webkit-style on attachment 45171 [details] without any errors.
Comment 9 WebKit Commit Bot 2009-12-20 02:01:17 PST
Comment on attachment 45171 [details]
add test for emulating italic when there are no italic versions of a glyph

Clearing flags on attachment: 45171

Committed r52407: <http://trac.webkit.org/changeset/52407>
Comment 10 WebKit Commit Bot 2009-12-20 02:01:28 PST
All reviewed patches have been landed.  Closing bug.