Bug 32692

Summary:

Index validation for drawElements examines too many indices

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

brettw, cmarrin, commit-queue, dglazkov, fishd, oliver, petersont, rlp, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Kenneth Russell 2009-12-17 19:01:35 PST

The index validation code added in https://bugs.webkit.org/show_bug.cgi?id=31239 verifies too many indices. It should compute its maximum index from the sub-region of the bound element array buffer indicated by the passed offset and count; instead, it checks all indices in the element array buffer, leading to failures of valid code.

Comment 1 Kenneth Russell 2009-12-17 19:14:44 PST

Created attachment 45121 [details]
Patch

Comment 2 WebKit Review Bot 2009-12-17 19:17:43 PST

style-queue ran check-webkit-style on attachment 45121 [details] without any errors.

Comment 3 WebKit Commit Bot 2009-12-18 11:43:26 PST

Comment on attachment 45121 [details]
Patch

Clearing flags on attachment: 45121

Committed r52327: <http://trac.webkit.org/changeset/52327>

Comment 4 WebKit Commit Bot 2009-12-18 11:43:31 PST

All reviewed patches have been landed.  Closing bug.