Bug 32692

Summary: Index validation for drawElements examines too many indices
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: brettw, cmarrin, commit-queue, dglazkov, fishd, oliver, petersont, rlp, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2009-12-17 19:01:35 PST
The index validation code added in https://bugs.webkit.org/show_bug.cgi?id=31239 verifies too many indices. It should compute its maximum index from the sub-region of the bound element array buffer indicated by the passed offset and count; instead, it checks all indices in the element array buffer, leading to failures of valid code.
Attachments
Patch (5.97 KB, patch)
2009-12-17 19:14 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2009-12-17 19:14:44 PST
Created attachment 45121 [details] Patch
WebKit Review Bot
Comment 2 2009-12-17 19:17:43 PST
style-queue ran check-webkit-style on attachment 45121 [details] without any errors.
WebKit Commit Bot
Comment 3 2009-12-18 11:43:26 PST
Comment on attachment 45121 [details] Patch Clearing flags on attachment: 45121 Committed r52327: <http://trac.webkit.org/changeset/52327>
WebKit Commit Bot
Comment 4 2009-12-18 11:43:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.