Bug 32669

Summary:

check-webkit-style should not mark moc files inclusion as errors

Product:

WebKit

Reporter:

Yael <yael>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, levin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch.	none

Description Yael 2009-12-17 10:01:59 PST

moc files are the "magic" behind Qt's signals and slots. These files must be included at the bottom of the cpp file which includes them, or compilation will fail.
check-webkit-style marks including these files as out-of-order. see https://bugs.webkit.org/show_bug.cgi?id=32555#c6 as an example.

Comment 1 Yael 2009-12-25 11:13:08 PST

Created attachment 45493 [details]
Patch.

Comment 2 WebKit Review Bot 2009-12-25 11:13:42 PST

style-queue ran check-webkit-style on attachment 45493 [details] without any errors.

Comment 3 Darin Adler 2009-12-25 20:07:16 PST

Comment on attachment 45493 [details]
Patch.

It would be even better if this rule was specific to Qt platform directories.

Comment 4 WebKit Commit Bot 2009-12-27 01:11:30 PST

Comment on attachment 45493 [details]
Patch.

Clearing flags on attachment: 45493

Committed r52575: <http://trac.webkit.org/changeset/52575>

Comment 5 WebKit Commit Bot 2009-12-27 01:11:35 PST

All reviewed patches have been landed.  Closing bug.