Bug 32646

Summary: Web Inspector: Switch to 11px as default for source-code in WebKit
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, mitz, rik, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] 10px
none
[IMAGE] 11px
none
[PATCH] Just in case you really, really like it! timothy: review+

Description Pavel Feldman 2009-12-16 23:45:32 PST
Some people (including myself and Joe) think that our font is too small and things are not clear. Some of these concerns are addressed via migrating to monospace. But not all. What do you say about trying out 11px as the default size?

- Web developers typically have big enough screens
- It looks good on my MBP
- Firebug does not hesitate using large fonts and people seem to like it.
- I made it 12px monospace in Chromium (that is ~11px Monaco)

Throwing some images in shortly.
Comment 1 Pavel Feldman 2009-12-16 23:51:16 PST
Created attachment 45039 [details]
[IMAGE] 10px
Comment 2 Pavel Feldman 2009-12-16 23:51:47 PST
Created attachment 45040 [details]
[IMAGE] 11px
Comment 3 Pavel Feldman 2009-12-16 23:56:25 PST
I encourage you to do side-by-side eval of the images. For me 11px looks much more clear and fits almost as much as 10px (15 lines vs 16 lines when attached).
Comment 4 Pavel Feldman 2009-12-16 23:59:19 PST
Created attachment 45041 [details]
[PATCH] Just in case you really, really like it!
Comment 5 WebKit Review Bot 2009-12-17 00:00:56 PST
style-queue ran check-webkit-style on attachment 45041 [details] without any errors.
Comment 6 Mark Rowe (bdash) 2009-12-17 00:49:24 PST
10px Monaco should be the default for Leopard and earlier.  11px Menlo should be the default for SnowLeopard.  This matches the default size and family of monospace fonts used elsewhere in the operating system.  We should match these defaults until we provide some means for users to adjust these to their personal preference (user stylesheet perhaps?).
Comment 7 Timothy Hatcher 2009-12-17 01:29:54 PST
I agree with Mark. Monaco >10px is just too ugly to use…

This really needs to be a setting as it is highly a personal opinion.
Comment 8 Timothy Hatcher 2009-12-17 01:31:54 PST
I personally can't get use to Menlo either (being antialiased and monospaced bothers me). But it might look decent in all the places that are no monospace that use to be an antialiased font… hmm.
Comment 9 Timothy Hatcher 2009-12-17 02:12:54 PST
I'm fine with 11px on Windows. But on Mac we need to match the system.
Comment 10 Timothy Hatcher 2009-12-17 09:35:34 PST
Comment on attachment 45041 [details]
[PATCH] Just in case you really, really like it!

Where did the Monaco reference go? If this is now just using the default monospace font (Monaco/Menlo), then the default font size will be implied from WebPreferences if you just do this:

font: monospace
Comment 11 Pavel Feldman 2009-12-17 09:38:44 PST
(In reply to comment #10)
> (From update of attachment 45041 [details])
> Where did the Monaco reference go? If this is now just using the default
> monospace font (Monaco/Menlo), then the default font size will be implied from
> WebPreferences if you just do this:
> 
> font: monospace

It is .source-code in inspector.js
Comment 12 Timothy Hatcher 2009-12-17 10:08:39 PST
Lets land this and see what people think. I suspect we will need to add settings for this soon. And default to wha tthe platform standard is (Monaco, Menlo, Consolas, etc).
Comment 13 Pavel Feldman 2009-12-17 10:29:58 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/inspector/front-end/inspector.css
Committed r52260