Bug 32625

Summary: Early Warning System doesn't obey system locale
Product: WebKit Reporter: Evan Martin <evan>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch for great justice
none
patch for great justice
none
patch for great justice none

Evan Martin
Reported 2009-12-16 11:55:09 PST
http://webkit-commit-queue.appspot.com/results/127615 Has some mojibake on it. ../../WebCore/page/SecurityOrigin.cpp: In member function ‘bool WebCore::SecurityOrigin::canAccess(const WebCore::SecurityOrigin*) const’: (bugzilla may eat that) It's because the builder is running in a UTF-8 locale, so it is outputting UTF-8. Since Mac/Win will only output ASCII, probably putting a UTF-8 encoding header on the page will probably be the easiest fix.
Attachments
patch for great justice (1.07 KB, patch)
2009-12-16 12:09 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
patch for great justice (1.68 KB, patch)
2009-12-16 12:19 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
patch for great justice (1.07 KB, patch)
2009-12-16 12:29 PST, Evan Martin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-12-16 12:01:37 PST
That should be easy to do. The web service is in WebKitTools/QueueStatusServer. Eric or I can re-deploy after the patch lands.
Evan Martin
Comment 2 2009-12-16 12:09:19 PST
Created attachment 45001 [details] patch for great justice
Evan Martin
Comment 3 2009-12-16 12:11:36 PST
(completely untested, btw, still getting started here)
WebKit Review Bot
Comment 4 2009-12-16 12:12:03 PST
style-queue ran check-webkit-style on attachment 45001 [details] without any errors.
Evan Martin
Comment 5 2009-12-16 12:18:05 PST
fail. equals sign instead of hyphen
Evan Martin
Comment 6 2009-12-16 12:19:00 PST
Created attachment 45003 [details] patch for great justice
WebKit Review Bot
Comment 7 2009-12-16 12:22:26 PST
style-queue ran check-webkit-style on attachment 45003 [details] without any errors.
Evan Martin
Comment 8 2009-12-16 12:29:56 PST
Created attachment 45005 [details] patch for great justice
WebKit Review Bot
Comment 9 2009-12-16 12:33:06 PST
style-queue ran check-webkit-style on attachment 45005 [details] without any errors.
Adam Barth
Comment 10 2009-12-16 13:10:19 PST
Comment on attachment 45005 [details] patch for great justice Thanks!
Adam Barth
Comment 11 2009-12-16 13:11:27 PST
Eric might be closer to the redeploy button than me.
Eric Seidel (no email)
Comment 12 2009-12-16 13:20:43 PST
I'm just gonna add Evan to the deploy list. He's a committer, no reason he shouldn't be able to deploy the app. Anyone who's hacking on the bots should have full access to deploy them, and I'm happy to make that a reality.
Eric Seidel (no email)
Comment 13 2009-12-16 13:22:03 PST
Invited Evan to developer access on http://webkit-commit-queue.appspot.com/
WebKit Commit Bot
Comment 14 2009-12-16 13:24:15 PST
Comment on attachment 45005 [details] patch for great justice Clearing flags on attachment: 45005 Committed r52218: <http://trac.webkit.org/changeset/52218>
WebKit Commit Bot
Comment 15 2009-12-16 13:24:22 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 16 2009-12-16 13:31:44 PST
Our handling of file data on the server might also be screwing you here: http://trac.webkit.org/browser/trunk/WebKitTools/QueueStatusServer/queue_status.py#L148 the str() call was added to work around a bug where Blob() can't handle u"" strings. Maybe we need to use BinaryBlob or something.
Evan Martin
Comment 17 2009-12-16 13:36:57 PST
(In reply to comment #13) > Invited Evan to developer access on http://webkit-commit-queue.appspot.com/ I don't see this. Did you invite evan@chromium.org?
Eric Seidel (no email)
Comment 18 2009-12-16 13:40:24 PST
No, I invited your gmail account. I'm happy to invite whichever account you like
Note You need to log in before you can comment on or make changes to this bug.