Summary: | Early Warning System doesn't obey system locale | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Evan Martin <evan> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Evan Martin
2009-12-16 11:55:09 PST
That should be easy to do. The web service is in WebKitTools/QueueStatusServer. Eric or I can re-deploy after the patch lands. Created attachment 45001 [details]
patch for great justice
(completely untested, btw, still getting started here) style-queue ran check-webkit-style on attachment 45001 [details] without any errors.
fail. equals sign instead of hyphen Created attachment 45003 [details]
patch for great justice
style-queue ran check-webkit-style on attachment 45003 [details] without any errors.
Created attachment 45005 [details]
patch for great justice
style-queue ran check-webkit-style on attachment 45005 [details] without any errors.
Comment on attachment 45005 [details]
patch for great justice
Thanks!
Eric might be closer to the redeploy button than me. I'm just gonna add Evan to the deploy list. He's a committer, no reason he shouldn't be able to deploy the app. Anyone who's hacking on the bots should have full access to deploy them, and I'm happy to make that a reality. Invited Evan to developer access on http://webkit-commit-queue.appspot.com/ Comment on attachment 45005 [details] patch for great justice Clearing flags on attachment: 45005 Committed r52218: <http://trac.webkit.org/changeset/52218> All reviewed patches have been landed. Closing bug. Our handling of file data on the server might also be screwing you here: http://trac.webkit.org/browser/trunk/WebKitTools/QueueStatusServer/queue_status.py#L148 the str() call was added to work around a bug where Blob() can't handle u"" strings. Maybe we need to use BinaryBlob or something. (In reply to comment #13) > Invited Evan to developer access on http://webkit-commit-queue.appspot.com/ I don't see this. Did you invite evan@chromium.org? No, I invited your gmail account. I'm happy to invite whichever account you like |