Bug 32616

Summary: [V8] There is no such thing as HTMLSelectElementCollection
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore JavaScriptAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32569    
Attachments:
Description Flags
Ain't no such thing as HTMLSelectElementCollectionCustom. fishd: review+

Dimitri Glazkov (Google)
Reported 2009-12-16 09:44:43 PST
In preparation for making all indexers generated, we should first eliminate this naming oops. I am the author of the oops -- a long time ago.
Attachments
Ain't no such thing as HTMLSelectElementCollectionCustom. (11.07 KB, patch)
2009-12-16 09:50 PST, Dimitri Glazkov (Google) 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-12-16 09:50:21 PST
Created attachment 44986 [details] Ain't no such thing as HTMLSelectElementCollectionCustom.
WebKit Review Bot
Comment 2 2009-12-16 09:52:03 PST
Attachment 44986 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebCore/bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp': Can't open for reading WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1
Dimitri Glazkov (Google)
Comment 3 2009-12-16 10:04:29 PST
Sorry, style-elf. I'll fix the order on landed.
Dimitri Glazkov (Google)
Comment 4 2009-12-16 11:27:27 PST
Landed as http://trac.webkit.org/changeset/52211.
Note You need to log in before you can comment on or make changes to this bug.