Bug 32611 – build-webkit --chromium can't handle changes to GYP files

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Adam Barth]

abarth@qbuntu:~/git/webkit-chromium-ews$ touch WebKit/chromium/base/base.gyp 
abarth@qbuntu:~/git/webkit-chromium-ews$ ./WebKitTools/Scripts/build-webkit --chromium
make -j4 BUILDTYPE=Release webkit
gyp_webkit -fmake --ignore-environment -Ibuild/common.gypi "--depth=." "-Dinside_chromium_build=0" "-Dv8_use_snapshot=false" "-Dmsvs_use_common_release=0" WebKit.gyp
/bin/sh: gyp_webkit: not found
make: *** [Makefile] Error 127

This is blocking the EWS.

[Adam Barth]

I've found a way to hack around the problem:

In WebKit/chromium/Makefile:

gyp_webkit -fmake --ignore-environment ......

should be

python gyp_webkit -fmake --ignore-environment ......

Now I just need to figure out where this file comes from.

[Adam Barth]

Found the bug:

abarth@qbuntu:~/git/webkit-qt-ews/WebKit/chromium/tools/gyp$ svn diff
Index: pylib/gyp/generator/make.py
===================================================================
--- pylib/gyp/generator/make.py	(revision 751)
+++ pylib/gyp/generator/make.py	(working copy)
@@ -1129,7 +1129,8 @@
         makefile_name,
         ' '.join(map(Sourceify, build_files)),
         gyp.common.EncodePOSIXShellList(
-            [gyp.common.FixIfRelativePath(params['gyp_binary'], options.depth),
+            ['python',
+             gyp.common.FixIfRelativePath(params['gyp_binary'], options.depth),
              '-fmake'] +
             gyp.RegenerateFlags(options) +
             build_files_args)))

Now I just need to figure out what the process is for upstreaming the fix.