Summary: | [GTK] segfault during volume notification | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, gustavo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Philippe Normand
2009-12-16 02:19:03 PST
We have reverted the patch for the time being, since we didn't find a fix in a timely manner. Created attachment 44989 [details] volume/duration notifications support I reapplied the patch from Bug 30377 also did some minor coding style fixes. It seems that setting the volume on playbin and just after connect to the notify::volume signal was causing problems. Anyway it was not needed as by default it is 1.0 both in playbin and in the MediaPlayer. Attachment 44989 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:923: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 1
|