Bug 32575

Summary: sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P2    
Version: 525.x (Safari 3.1)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 68469, 26389    
Description Flags
Fix of Filter source position none

Description Dirk Schulze 2009-12-15 13:15:51 PST
sourceGraphic is on the wrong position if values of filter: x,y are positive and filterUnits=objectBB. This is caused by the clipping of the sourceImage rect to the filter rect. I have already a patch for it, but need to run LayoutTests first.
Comment 1 Dirk Schulze 2009-12-16 00:06:36 PST
Created attachment 44951 [details]
Fix of Filter source position

On SVG Filters, the rest of the source graphic gets clipped to the filter rest. This helps us to minimize the size of intermediate ImageBuffers. If the position moves to the right or to the bottom, we have to adjust the GraphicContext of this intermediate ImageBuffer.
This patch fixes the adjustment of the context, according to the clipping.
Comment 2 WebKit Review Bot 2009-12-16 00:09:44 PST
style-queue ran check-webkit-style on attachment 44951 [details] without any errors.
Comment 3 WebKit Commit Bot 2009-12-16 10:13:03 PST
Comment on attachment 44951 [details]
Fix of Filter source position

Clearing flags on attachment: 44951

Committed r52202: <http://trac.webkit.org/changeset/52202>
Comment 4 WebKit Commit Bot 2009-12-16 10:13:10 PST
All reviewed patches have been landed.  Closing bug.