Bug 32525 – Assertion failure in addStyleMarkup copying link text (from maps.google.com at least)

• Component: HTML Editing
• Status: RESOLVED CONFIGURATION CHANGED

[John Sullivan]

To reproduce:

1. visit maps.google.com
2. click-and-drag to select the word "Maps" in the "Put <your business on Google Maps>" link on the left side. (Selecting more of the link will also show the bug. It doesn't happen with all the links on this page though.)
3. Command-C to Copy

ASSERTION FAILED: propertyMissingOrEqualToNone(style, CSSPropertyTextDecoration) && propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect)

The assertion is here:

static void addStyleMarkup(Vector<String>& preMarkups, Vector<String>& postMarkups, CSSStyleDeclaration* style, Document* document, bool isBlock = false)
{
    // All text-decoration-related elements should have been treated as special ancestors
    // If we ever hit this ASSERT, we should export StyleChange in ApplyStyleCommand and use it here
    ASSERT(propertyMissingOrEqualToNone(style, CSSPropertyTextDecoration) && propertyMissingOrEqualToNone(style, CSSPropertyWebkitTextDecorationsInEffect));


The assertion and preceding comment were added by Ryosuke Niwa ([e-mail]) in r46446.

I don't know what effect this would have on a release build, but I suspect it is minor. 

This is in Radar as rdar://problem/7469282.

[Ryosuke Niwa]

I thought http://trac.webkit.org/changeset/49129 fixed the assertion problem but it seems like it wasn't the case.  I feel like we need the real surgery.  See https://bugs.webkit.org/show_bug.cgi?id=28710 for more information.

[Ryosuke Niwa]

Created attachment 45117 [details]
copying a link inside a table cell causes an assertion failure

It turned out that this assertion fails when a link inside a table cell is copied.

[Ahmad Saleem]

I am not able to get assert in DEBUG build on WebKit ToT (260689@main) on both WK1 and WK2 window and tried to copy link just Maps and also full link and link with text as well and no assert.

Do we need to track it?

[Brent Fulgham]

<rdar://7469282>