Bug 32522

Summary: [Android] Android needs ResourceError, ResourceResponse and ResourceRequest implementation.
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: WebCore Misc.Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, benm, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Adds implementation of ResourceError, ResourceRequest and ResourceResponse
none
Adds implementation of ResourceError, ResourceRequest and ResourceResponse (v2) darin: review+, benm: commit-queue-

Description Andrei Popescu 2009-12-14 09:10:59 PST
Android needs implementation for ResourceError, ResourceResponse and ResourceRequest. These are loading-related classes that a port of WebKit needs to implement.
Comment 1 Andrei Popescu 2009-12-14 09:15:22 PST
Created attachment 44801 [details]
Adds implementation of ResourceError, ResourceRequest and ResourceResponse
Comment 2 WebKit Review Bot 2009-12-14 09:17:20 PST
Attachment 44801 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/network/android/ResourceResponse.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1
Comment 3 Andrei Popescu 2009-12-14 09:22:50 PST
Created attachment 44802 [details]
Adds implementation of ResourceError, ResourceRequest and ResourceResponse (v2)

Fixes the Alphabetical sorting problem.
Comment 4 Darin Adler 2009-12-14 09:25:12 PST
Comment on attachment 44802 [details]
Adds implementation of ResourceError, ResourceRequest and ResourceResponse (v2)

> +struct ResourceRequest : ResourceRequestBase {

This should be a class, not a struct.
Comment 5 Andrei Popescu 2009-12-14 11:00:56 PST
(In reply to comment #4)
> (From update of attachment 44802 [details])
> > +struct ResourceRequest : ResourceRequestBase {
> 
> This should be a class, not a struct.

Ok, Ben Murdoch will change to a class on landing. I've verified that it all works fine with class instead of struct. Thanks for the review.

Andrei
Comment 6 Ben Murdoch 2009-12-14 11:35:18 PST
Yep, assigning to myself for manual landing.
Comment 7 Ben Murdoch 2009-12-14 12:02:00 PST
Landed as r52105.