Summary: | [Android] Android needs ResourceError, ResourceResponse and ResourceRequest implementation. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrei Popescu <andreip> | ||||||
Component: | WebCore Misc. | Assignee: | Ben Murdoch <benm> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | android-webkit-unforking, benm, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Android | ||||||||
OS: | Android | ||||||||
Attachments: |
|
Description
Andrei Popescu
2009-12-14 09:10:59 PST
Created attachment 44801 [details]
Adds implementation of ResourceError, ResourceRequest and ResourceResponse
Attachment 44801 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/network/android/ResourceResponse.h:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1
Created attachment 44802 [details]
Adds implementation of ResourceError, ResourceRequest and ResourceResponse (v2)
Fixes the Alphabetical sorting problem.
Comment on attachment 44802 [details] Adds implementation of ResourceError, ResourceRequest and ResourceResponse (v2) > +struct ResourceRequest : ResourceRequestBase { This should be a class, not a struct. (In reply to comment #4) > (From update of attachment 44802 [details]) > > +struct ResourceRequest : ResourceRequestBase { > > This should be a class, not a struct. Ok, Ben Murdoch will change to a class on landing. I've verified that it all works fine with class instead of struct. Thanks for the review. Andrei Yep, assigning to myself for manual landing. |