Summary: | AX: there's an infinite loop going on for some webpages - facebook.com | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
chris fleizach
2009-12-13 16:22:39 PST
Created attachment 44769 [details]
patch
the problem is that we can't call parentObjectUnignored while in accessibilityIsIgnored... it leads to a lot of recursiveness that might not ever end...
it was being done when determining if an object was within a ARIA tree. that check should
1) be moved to all platforms
2) not call parentObjectUnignored()
style-queue ran check-webkit-style on attachment 44769 [details] without any errors.
Comment on attachment 44769 [details]
patch
That test case is huge. Is it possible to test the issue with a reduced test case?
More problematically, that HTML looks to be a derivative work of Facebook. I suspect we don't have the right to re-license it under the BSD license.
the bug looks like its a result of the huge number of elements on the page, not in any particular snippet. i can only resubmit without a layout test Created attachment 44773 [details]
patch
this patch omits the layout test. the slow down captured by this bug is a result of pages that have deeply nested hierarchy and a lot of it. i can't simulated a page without copying another webpage
style-queue ran check-webkit-style on attachment 44773 [details] without any errors.
Comment on attachment 44773 [details]
patch
need to see if i can create a test
Created attachment 44774 [details]
patch
made a test that gets the behavior. we just needed a lot of elements inside of each other
style-queue ran check-webkit-style on attachment 44774 [details] without any errors.
|