Bug 32438

Summary:

svn-apply can't handle git diffs generated with --no-prefix

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Chris Jerdonek <cjerdonek>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, aroben, cjerdonek, dbates

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	none

Eric Seidel (no email)

Reported 2009-12-11 10:03:07 PST

svn-apply can't handle git diffs generated with --no-prefix https://bugs.webkit.org/show_bug.cgi?id=32335#c11

Attachments
Proposed patch (3.30 KB, patch) 2010-05-03 19:56 PDT, Chris Jerdonek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-04-18 13:27:10 PDT

Struck again! https://bugs.webkit.org/show_bug.cgi?id=20219#c14 Seems we should at least make svn-apply error out nicely in this case. Right now it silently fails.

Chris Jerdonek

Comment 2 2010-05-03 19:56:40 PDT

Eric Seidel (no email)

Comment 3 2010-05-03 20:18:46 PDT

Comment on attachment 54986 [details] Proposed patch LGTM.

Chris Jerdonek

Comment 4 2010-05-04 01:01:29 PDT

Comment on attachment 54986 [details] Proposed patch Clearing flags on attachment: 54986 Committed r58741: <http://trac.webkit.org/changeset/58741>

Chris Jerdonek

Comment 5 2010-05-04 01:01:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.