Bug 32417

Summary: [Qt] The "Search" input type is not rendered correctly when styled.
Product: WebKit Reporter: Petri Ojala <peojala11>
Component: WebKit QtAssignee: Carol Szabo <carol>
Status: RESOLVED FIXED    
Severity: Normal CC: agl, carol, commit-queue, eric, evan, hausmann, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 30173    
Attachments:
Description Flags
Proposed Patch none

Description Petri Ojala 2009-12-11 04:12:17 PST 
Load any page that has a styled "search" input such as:
http://waplabdc.nokia-boston.com/browser/users/caszabo/feat/forms/search3.htm

Result:
the "Search" input type is not rendered correctly when styled.
Comment 1 Carol Szabo 2009-12-11 05:09:28 PST 
This is partly covered under bug 30173
Comment 2 Carol Szabo 2009-12-18 08:31:04 PST 
Patch coming soon.
Comment 3 Carol Szabo 2009-12-18 12:35:02 PST 
Created attachment 45173 [details]
Proposed Patch

This patch changes the handling of the search control, deferring the painting of the background and borders to WebCore.
Comment 4 WebKit Review Bot 2009-12-18 12:38:21 PST 
style-queue ran check-webkit-style on attachment 45173 [details] without any errors.
Comment 5 Eric Seidel (no email) 2009-12-22 16:45:28 PST 
Comment on attachment 45173 [details]
Proposed Patch

Doesn't Qt have pixel test results which will need updating?  I guess those can be done separate...
Comment 6 WebKit Commit Bot 2009-12-22 18:26:19 PST 
Comment on attachment 45173 [details]
Proposed Patch

Clearing flags on attachment: 45173

Committed r52518: <http://trac.webkit.org/changeset/52518>
Comment 7 WebKit Commit Bot 2009-12-22 18:26:24 PST 
All reviewed patches have been landed.  Closing bug.